Repository navigation
Conversation
The admin settings API is only accessible for admins, but this is called for every user. This causes blocking errors for non-admin users. The original purpose of /settings is to deliver public settings to non-admin users. But since this has been removed, these lines should also be removed.
Collaborator
Author
|
The new UI in the dev branch look great btw! One small note: when I mark a challenge as solved, I enter the flag and I accidentally mark the challenge as unsolved again, the flag is gone. It is not that difficult to mark it as unsolved and I would expect that the flag would be still there (in the database) even when the task is not marked as solved. |
Collaborator
Author
|
Closing due to outdated |
JJ-8
added a commit
to woutvanderploeg/CTFNote
that referenced
this pull request
Jun 17, 2023
Revert "Update illegal dates migration ID to 43"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried the dev branch, I got some errors and I have already the fix:
The admin settings API is only accessible for admins, but this is called for every user. This causes blocking errors for non-admin users.
The original purpose of /settings is to deliver public settings to non-admin users. But since this has been removed, these lines should also be removed.