Multiple named page templates - #8
Closed
connorferster wants to merge 2 commits into
Closed
Conversation
Replace the first-page/remaining-pages document model with named page
templates. `_doc.templates` is a mapping of name -> {margins, background};
the first entry is the starting template. Page size and orientation remain
document-wide.
Add source-level template switching:
- `_pagebreak` accepts an optional template name/index for following pages
- `_nextpagetemplate` arms the template to switch to at the next break
Template flow is managed by ReportLab's NextPageTemplate. Each PageTemplate
records a page-index -> template-name map during the build so post-processing
can overlay the correct background per page. Config merge treats `templates`
as a whole mapping from the highest-priority layer.
Migrate defaults, test configs, examples, and docs to the new schema; add
tests covering template resolution, both blocks, the build-time page map,
and the config merge.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the first-page/remaining-pages document model with named page templates, and adds source-level switching.
Changes
_doc.templatesis a mapping of name →{margins, background}; the first entry is the starting template. Page size and orientation remain document-wide._pagebreak: <name-or-index>breaks and switches the template for following pages;_nextpagetemplate: <name-or-index>arms the switch for the next break.NextPageTemplate. EachPageTemplaterecords apage-index → template-namemap during the build so post-processing overlays the correct background per page.templatesas a whole mapping from the highest-priority layer.Breaking change
Pre-1.0 config break:
first-page/remainingis removed; documents adopt thetemplates:schema. Migrates defaults, test configs, examples, and docs.Testing
Tests cover template resolution (name/index), both blocks, the build-time page→template map, config merge, and per-template background overlay.
Merge notes
Branched off
main. Independent of the other two feature PRs (touchesconfig/doctemplate.py,pdf_postprocessing.py,context_builder.py,report_reader.py) — no expected overlap with the list/text-style branches. Also fixes the_doc.backgroundbare-string validation issue those branches still carry.🤖 Generated with Claude Code