Skip to content

Fixes/new geometry problems #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorferster merged 3 commits into from
Nov 27, 2025
Merged

Fixes/new geometry problems #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c91a0fb
chore: remove debug print
connorferster Nov 21, 2025
ee5caa6
fix: changed how intersections were calculated in geom_ops.sort_supports
connorferster Nov 21, 2025
98f266f
Merge branch 'main' into fixes/new_geometry_problems
connorferster Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/papermodels/datatypes/element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import tomli_w
import json


Geometry = Union[LineString, Polygon]

ELEMENT_ATTRS = {
Expand Down Expand Up @@ -277,6 +278,9 @@ def get_collector_extents(self, relative: bool = True) -> dict[str, tuple]:
for idx, poly_support_geom in enumerate(support_geoms):
clean_support_geom = support_geoms[idx]
cleaned_supports_map.update({clean_support_geom: poly_support_geom})
assert all(
[self.geometry.intersects(support) for support in support_geoms]
)
try:
ordered_support_geoms = geom_ops.sort_supports(
self.geometry, support_geoms
Expand Down
1 change: 1 addition & 0 deletions src/papermodels/datatypes/joist_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ def generate_joist_geom(self, index: int):
# joist_geom = LineString([end_a, end_b])
if joist_geom.length <= self._cantilever_tolerance:
return None

return joist_geom

def get_extent_edge(self, edge: str = "start"):
Expand Down
Loading