Repository navigation
Conversation
…packages assets/public and assets/private are workspace packages, but Renovate didn't check out the submodules, so every lockfile it updated dropped their importers. pnpm install --frozen-lockfile then failed anywhere the submodules were checked out, including the deploy.
If Renovate can't clone the asset submodules, it only logs a warning and updates the lockfile without them, which breaks pnpm install --frozen-lockfile wherever the submodules are checked out, including the deploy. Catch that on the pull request instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
ugcodrr
added a commit
that referenced
this pull request
Oct 21, 2026
This PR keeps only the Next bump. Reverts "ci: fail when the lockfile loses the asset packages" and "chore(renovate): clone submodules so lockfile updates keep the asset packages".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Renovate never checked out the asset submodules, so every lockfile it updated dropped assets/public and assets/private and broke
pnpm install --frozen-lockfilewherever they're checked out.Testing: the check passes on main's lockfile and fails on #882's.