[JazzyMichael]

Resolves: 492

Adds support for Search Criteria and nested parameter fields for rules.

This recording demonstrates the current application without the "search" option in the UI. Since search functionality is implemented in the back-end but not the front-end, navigating to a rule that uses search crashes the application.

Search-Feature-Before.mov

This next recording demonstrates the changes: Added search criteria input fields, as well as not crashing the app when selecting a rule using search:

Search-Feature-Recording.mov

[pradnya-orchestral]

@Jappzy , I have tested your changes, if we are selecting search from dropdown list, then condition is mandatory fields, so there should be some parameter field need to send from UI while saving data in PUT API to backend, so that we can get something for condition parameter in GET API. Here, need to check this because we are not getting anything for condition parameter in Get API so that on UI it is showing empty, I have made red square to highlight in following screenshot. Can you please check this?

[JazzyMichael]

@pradnya-orchestral Could you re-test? I added a screen recording and fixed the default values getting included in the PUT request.

[mickmcgrath13]

@pradnya-orchestral are you able to re-review?

@Jappzy once things are good, we'll need to merge master -> this branch

[CLAassistant]

All committers have signed the CLA.

[nzlosh]

@pradnya-orchestral have you been able to test since @Jappzy applied the fixes for the problem you mentioned?

[cognifloyd]

From reading and based on the screen recording, this looks good to me. Without any more experienced JS reviewers, I'm inclined to merge this. If there are any issues, they should be found before release.

[arm4b]

The feature implementation is missing the main point of rule with search criteria which could include multiple patterns.

And so this rule fails to render, despite being properly registered in st2:

---
name: test_search2_err
pack: st2
description: "Test search rule in web ui with multiple criteria patterns"
enabled: true

trigger:
  type: "core.st2.webhook"
  parameters:
    url: "webhook-alert/handle-alert"

criteria:
  trigger.body.alert:
    type: "search"
    condition: any
    pattern:
      item.data:
        type: "equals"
        pattern: "foo"
      item.time: # additional pattern added
        type: "equals"
        pattern: "12:00"

action:
  ref: "core.echo"
  parameters:
    message: "{{ trigger.body }}"

https://docs.stackstorm.com/rules.html#advanced-comparison highlights more examples

[arm4b]

There are more search conditions supported, according to https://docs.stackstorm.com/rules.html#advanced-comparison

Suggested change

	const searchConditions = {
	'any': 'Any',
	'all': 'All',
	};
	const searchConditions = {
	'any': 'Any',
	'all': 'All',
	'any2any': 'Any2Any',
	'all2any': 'All2Any',
	};

[arm4b]

Looks like there was a misunderstanding in implementation and so this PR is always expecting to have item.data in the rule pattern.

I now see this is coming from the example:
https://github.com/bitovi-stackstorm-exchange/st2-ui-workflow-tests/blob/main/rules/validate-alert.yaml#L16

But based on https://github.com/bitovi-stackstorm-exchange/st2-ui-workflow-tests/blob/4f576228aad17652ceb47b1f444f2624f4c116c8/rules/validate-alert.yaml#L21

instead of item.data could be item.foo, item.bar and so on, as that refers to the dictionary item.

And so based on implementation here, this works:

---
name: test_search1_ok
pack: st2
enabled: true

trigger:
  type: "core.st2.webhook"
  parameters:
    url: "webhook-alert/handle-alert"

criteria:
  trigger.body.alert:
    type: "search"
    condition: any
    pattern:
      item.data: # works
        type: "equals"
        pattern: "foo"

action:
  ref: "core.echo"
  parameters:
    message: "{{ trigger.body }}"

While this rule doesn't (it should):

---
name: test_search1_err
pack: st2
enabled: true

trigger:
  type: "core.st2.webhook"
  parameters:
    url: "webhook-alert/handle-alert"

criteria:
  trigger.body.alert:
    type: "search"
    condition: any
    pattern:
      item.time: # changed, it's just a dict item
        type: "equals"
        pattern: "foo"

action:
  ref: "core.echo"
  parameters:
    message: "{{ trigger.body }}"