Repository navigation
WIP: Labels - #5415
WIP: Labels#5415cognifloyd wants to merge 14 commits into
Conversation
pull-request-size
Bot
added
the
size/L
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
@armab I'm slowly working through labels and colors to try and come up with some kind of systematic color scheme. All random colors means the colors have no meaning at all. I'm trying to give the colors common meaning.
I started by setting putting in the colors as they are now, and then resetting the standard github labels back to the github standard colors + descriptions. Then, I started grouping the labels and looking for a color to use for each group of labels.
What do you think of the grouping?
What about the colors?
| # ##### area/code_location labels ##### # | ||
| - color: 0075ca # blue (standard github) | ||
| description: Improvements or additions to documentation | ||
| name: documentation | ||
| - color: 0075ca # blue | ||
| description: "" | ||
| name: API |
There was a problem hiding this comment.
I think we can use this color of blue for area/code_location and area/python labels. Here is how #0075ca looks in dark and light mode:
| - color: cfd3d7 # gray (standard github) | ||
| description: This issue or pull request already exists | ||
| name: duplicate # status:duplicate | ||
| - color: e4e669 # yellow (standard github) | ||
| description: This doesn't seem right | ||
| name: invalid # status:invalid | ||
| - color: ffffff # white (standard github) | ||
| description: This will not be worked on | ||
| name: wontfix # status:wontfix |
There was a problem hiding this comment.
I think these three labels should have the status: prefix like the rest of the status labels.
| - color: d73a4a # red (standard github) | ||
| description: Something isn't working | ||
| name: bug | ||
| - color: d73a4a | ||
| description: "" | ||
| name: bug fix |
There was a problem hiding this comment.
Let's replace bug fix with just bug. If it's an issue labeled bug, then it describes a bug. If it's a PR labeled bug then it fixes a bug.
| - color: d73a4a # red (standard github) | |
| description: Something isn't working | |
| name: bug | |
| - color: d73a4a | |
| description: "" | |
| name: bug fix | |
| - color: d73a4a # red (standard github) | |
| description: Something isn't working | |
| name: bug |
| # ##### area/pack_resources labels ##### # | ||
| - color: 003459 # blue | ||
| description: "" | ||
| name: action aliases |
There was a problem hiding this comment.
I think we can use this color of blue for area/pack_resources labels. Here is how #003459 looks in dark and light mode:
| # ##### area/external_services labels ##### # | ||
| - color: 8336ff # blue | ||
| description: "" | ||
| name: database |
There was a problem hiding this comment.
I think we can use this color of purple for area/external_services and area/logging_and_performance labels. Here is how #8336ff looks in dark and light mode:
| # ##### area/install labels ##### # | ||
| - color: 50209c # purple | ||
| description: "" | ||
| name: deployment |
There was a problem hiding this comment.
I think we can use this color of purple for area/install labels. Here is how #50209c looks in dark and light mode:
| # ##### area/security labels ##### # | ||
| - color: 63112b # red purple | ||
| description: "" | ||
| name: RBAC | ||
| - color: 63112b # red purple | ||
| description: "" | ||
| name: security |
There was a problem hiding this comment.
And I opted for a more red/purple #63112b for the area/security labels.
Experimenting with a label changing workflow. Do not merge.
The idea is to adjust the label colors and descriptions in a file that we check into the repo.
Current labels list is an export made with https://github.com/micnncim/label-exporter
Eventually, I'll work on updating the label colors and descriptions.
tests of labels workflow: