Repository navigation
gha: add bootstrap_repo workflow & task for incubator CI - #133
Merged
Merged
Conversation
we need to let all with write access merge PRs. restricting pushes to TSC also prevents non-TSC from merging PRs. also, we need to remove admin access from the bot at the end.
|
|
env context is not available to define outputs
cognifloyd
marked this pull request as ready for review
May 19, 2022 06:31
Member
Author
|
Hooray! This is ready for review. See details here: StackStorm-Exchange/exchange-incubator#172 (comment) |
arm4b
approved these changes
May 19, 2022
arm4b
left a comment
arm4b
left a comment
Member
There was a problem hiding this comment.
The amount of dedication definitely feels here.
Looks really nice & clean 👍
| "dismissal_restrictions": {}, | ||
| "dismiss_stale_reviews": false, | ||
| "require_code_owner_reviews": true, | ||
| "required_approving_review_count": 1, |
| # So, we patch it separately. | ||
| run: > | ||
| gh api -X PUT '/orgs/{owner}/teams/${{ inputs.tsc_team }}/repos/{owner}/{repo}' | ||
| -f permission=maintain |
| pack_repo_template: | ||
| type: string | ||
| required: false | ||
| default: StackStorm-Exchange/ci-pack-template |
gha is actually case-insensitive here, so this is purely a cosmetic change.
Member
Author
|
Thanks for the review @armab ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR for StackStorm-Exchange/exchange-incubator#172