fix(panel): scroll the outcomes overview with the arrow keys - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↑↓ stopped scrolling the Outcomes overview after #194. The key handler scrolls by grabbing the first NSScrollView in the panel, which was fine while every tab only had one, but the tab strip is a sideways ScrollView now and sits above every page so it won. The arrows were scrolling the tab strip vertically, which has nowhere to go.
Same bug on the Usage detail pane and ⌘↑↓ on both, since they all went through the same lookup.
Now it takes the first scroll view whose content actually overflows vertically. If nothing overflows it finds nothing, which is fine as there's nothing to scroll anyway.
Unit tested with plain NSScrollViews (strip above an overflowing pane, and nothing overflowing). Haven't eyeballed it in the app yet, it relies on SwiftUI giving the tab strip content the same height as its viewport.