feat(ENG-2732): give the picker header the same glass as its footer - #208
Closed
adefreitas wants to merge 1 commit into
Closed
adefreitas wants to merge 1 commit into
adefreitas wants to merge 1 commit into
Conversation
The search field and category chips now sit on one pinned frosted surface with the integration list scrolling beneath them, matching the footer. The chip strip painted an opaque card-background inside the header, which covered half of that surface. The glass sits behind the whole header instead, and the search field is already a ghost Input, which no longer paints a fill of its own. Needs malachite's glassHeader, so this merges after that release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ENG-2732. Draft: blocked on StackOneHQ/malachite#413 merging and releasing.
The picker's footer is already frosted glass. This gives the header the same treatment, so the search field and category chips read as one pinned surface with the integration list scrolling beneath them.
Two lines:
glassHeaderon the pickerCard.card-backgroundinside the header, which covered half the glass. Removed, so the glass sits behind the whole header. The search field is already aghostInput, which after malachite#413 paints no fill of its own.Ordering
glassHeaderdoes not exist in a released malachite yet. Our range is^2.22.0, so the version carrying it is picked up without a manifest change, but this should not merge until that release is out.Verified
Ran the picker in
dev/viteagainst a local malachite build, light and dark: rows pass under both surfaces with no hard clip, the header tints with whatever scrolls beneath it, and the list sits flush under the header with the footer keeping its clearance.