avoid 'prefill' border when 'inpaint_border' is disabled - #231
Merged
Merged
Conversation
kostarion
commented
May 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
| if args.border == 'wrap' and args.animation_mode != '2D': | ||
| args.border = 'reflect' | ||
| logger.warning(f"Border 'wrap' is only supported in 2D mode, switching to '{args.border}'.") | ||
| if args.border == 'prefill' and args.animation_mode in ('2D', '3D warp') and args.inpaint_border == False: |
Contributor
There was a problem hiding this comment.
Should this be args.animation_mode != '3D render' instead of checking against 2D and 3D warp? Otherwise will hit same issue with Video Input potentially.
Contributor
Author
There was a problem hiding this comment.
Video Input mode doesn't apply any bordering, so the selected border is idle in this case
pharmapsychotic
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.