Animated color match + sync 2D/3D camera directions - #229
Conversation
- Update clip_guidance default to None to match docs - Update DATA_GENERATOR name that goes in saved settings files - Give example prompt for "3D warp rotate" preset and use pure MiDaS for better result - Fix Project import and delete and give Confirm button before deleting - Handle exceptions from `create_video_from_frames`
… it says desired movement of camera instead of movement of image plane so that settings match between 2D and 3D
| prev, next, tween = self.get_key_frame_tween(frame_idx) | ||
|
|
||
| if prev not in self.color_match_images: | ||
| self.color_match_images[prev] = self._span_render_frame(prev, self.args.seed) |
There was a problem hiding this comment.
You use _span_render_frame just because it incapsulates all the cumbersome generation parameter setup that you need, right? Should it be called differently then? Smth like just _generate_frame? I worry it might confuse since it's used not only in the span_cadence mode now.
There was a problem hiding this comment.
Yeah I think that's a good idea_span_render_frame -> _render_frame standalone simple frame render function used internally.
| width, height, tile_size = blended.width, blended.height, 64 | ||
| for y in range(0, height, tile_size): | ||
| for x in range(0, width, tile_size): | ||
| cut = next_match.crop((x, y, x + int(tile_size * tween), y + int(tile_size * tween))) |
There was a problem hiding this comment.
Hm, why not just the weighted sum of prev_match and next_match?
And maybe add an in-code comment also, because it doesn't seem obvious.
There was a problem hiding this comment.
That would introduce new colors in between the palettes instead of transitioning from colors of one to colors of the other. The blended image here has only RGB values that are present in either no new colors introduced this way.
|
SonarCloud Quality Gate failed.
|
2 participants
No description provided.