Skip to content

email verification in REGISTER/CONFIRMAGREEMENT - #458

Merged
gajop merged 3 commits into
Spring-Chobby:masterfrom
silentwings:master
Feb 13, 2019
Merged

email verification in REGISTER/CONFIRMAGREEMENT#458
gajop merged 3 commits into
Spring-Chobby:masterfrom
silentwings:master

Conversation

@silentwings

Copy link
Copy Markdown
Contributor

can be tested on the dev lobbyserver 78.46.100.157:7200

@gajop gajop left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this UI should only be displayed for uberserver connections, so it can still be used for ZK which doesn't have an email registration afaik.

@gajop gajop left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number tweaks.

PS: did you try using ZK protocol to make sure nothing broke?

Comment thread LuaMenu/widgets/chobby/components/login_window.lua
Comment thread LuaMenu/widgets/chobby/components/login_window.lua
Comment thread LuaMenu/widgets/chobby/components/login_window.lua
@silentwings

silentwings commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

The changes to positions are to allow enough space for an extra input box for email addresses / verifications. All font size changes are wanted, they reflect the lengths of text & space available.

(I think you may want to simply test it!)

@silentwings

Copy link
Copy Markdown
Contributor Author

I don't have any knowledge of ZKs protocol, or know where to find any documentation for it. Afaik this PR now does not affect the cmds sent unless protocol=="spring".

@gajop

gajop commented Feb 13, 2019

Copy link
Copy Markdown
Member

I mainly wanted to confirm that GUI still works well, with decent layout and behavior. I'll check it out when I have some time!

@gajop
gajop merged commit 3fd31b4 into Spring-Chobby:master Feb 13, 2019
@gajop

gajop commented Feb 13, 2019

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants