Auth session type - #292
Merged
Merged
Conversation
bourgeoa
added
enhancement
timea-solid
approved these changes
Jun 12, 2026
Member
|
it looks ok to me but I don't really know in detail. |
NoelDeMartin
approved these changes
Jun 12, 2026
NoelDeMartin
left a comment
NoelDeMartin
left a comment
Member
There was a problem hiding this comment.
I'm also not sure, but I'll approve because this looks like just a backwards compatible or improvement on the previous code, so I guess it's better than what it was before.
Not sure about the webpack-cli upgrade, though, was that necessary?
Contributor
Author
|
@NoelDeMartin This was with the purpose to type authSession and remove the webpack-cli just came in with npm i. I did not ask for it. I could have avoided to commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types authSession OIDC client