Repository navigation
Add bifacial panels support - #24
Merged
Merged
Conversation
Contributor
|
This all looks fine to me... it's still in Draft status, did you have more work to do on this? |
eljpsm
marked this pull request as ready for review
October 27, 2026 08:11
msqr
requested changes
Oct 28, 2026
msqr
left a comment
msqr
left a comment
Contributor
There was a problem hiding this comment.
Changing over to BDD AssertJ/Mockito style tests is my only request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new arguments for the bifacial panels support.
A small detail is that it won't work with every
model, apparently it only supportsisotropicorhaydavies(https://pvlib-python.readthedocs.io/en/v0.16.1/reference/generated/pvlib.bifacial.infinite_sheds.get_irradiance.html).