Repository navigation
Feat/3dgs star - #142
Open
akacete wants to merge 9 commits into
Open
Feat/3dgs star#142akacete wants to merge 9 commits into
akacete wants to merge 9 commits into
Conversation
… the other interfaces
…meImagesReleased setter
jim-bcom
approved these changes
Oct 13, 2026
jim-bcom
left a comment
jim-bcom
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall.
But just for the record, you seem to have cherry-picked a commit from #141 , so this branch is partially included in this one. There is also a common base with feat/o3d.
What do you think of:
- first merging
feat/new-sfm-segmentation-servicein master - then rebase your branch on it.
- And maybe merge the fix in
feat/o3din it. - And finally merge
feat/3dgs_starin master ?
Or, other solution:
3. merge feat/3dgs_star in master
4. create another PR for feat/o3d?
| /// @brief Setter: marks the keyframe images as released by clearing the embed flag, | ||
| /// so they are no longer serialized with the map | ||
| /// | ||
| void keyframeImagesReleased(); |
Contributor
There was a problem hiding this comment.
nit: naming convention consistency, keyframeImagesReleasedsounds more like an event name. What about releaseKeyframeImages, or excludeImages(). We coud also have withImages() and withoutImage(), but this would require to refactor existing usage of embedKeyframeImages()...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.