Skip to content

Uncleared function name reference: Function section and call information #350

Open

Description

@OEG-Clark

With the review of 12,000 repos, I have found the reference for function names ambiguous. For example, in the image given below, we could see there are two select_builder, but the reference name is different.
image

It would be beneficial if for each repo, we could have a functions list or index. Or if inspect4py could unify the naming scheme for each function. For example, we could define the inspect4py result as folder.file.(class).function_name, which would keep the uniqueness and cohesion of each function/class name.

Activity

  1. dgarijo commented on Jun 20, 2022

    @dgarijo
    Collaborator

    I think the problem here is that select_builder. is very strange. Please post here the original source code and the repository name, so we can identify it

  2. added this to the v0.0.2 milestone on Jun 20, 2022
  3. self-assigned this
    on Jun 20, 2022
  4. OEG-Clark commented on Jun 21, 2022

    @OEG-Clark
    ContributorAuthor
  5. OEG-Clark commented on Jun 21, 2022

    @OEG-Clark
    ContributorAuthor

    Another issue that could occur is given by the following.

    The image below shows a piece of call information from a function named ds_item. So the direction for this function is pipetools/ds_builder.ds_tiem. And you could see the reference for a function is ds_builder.DSBuilder which is file.function_name, however, there is a call from the same folder which is pipetools, and it is named pipetools.main.StringFormatter which is folder.file.function.

    The reference is https://github.com/0101/pipetools/blob/master/pipetools/ds_builder.py#:~:text=return%20builder-,def%20ds_item(definition%2C%20data)%3A,return%20definition,-%C2%A9%202022%20GitHub%2C%20Inc.

    image

  6. dgarijo commented on Jun 21, 2022

    @dgarijo
    Collaborator

    So the problem is that ds_builder.DSBuilder should have been pipetools.ds_builder.DSBuilder.

    Basically, the package structure should be dded in the local files too.

  7. modified the milestones: v0.0.2, v0.0.3 on Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions