Conversation
🎉 Bazel & CI Test Results
All Bazel configuration and CI tests passed! ✨ The build system and core tooling are working correctly. 🚀 Bazel remote cache is now enabled - future builds will be faster! Workflow: Valdi CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ran into an edge-casey issue where
createDirectorySynccan report success without creating the directory.FileStatderivesisDir/isFile/ size from a struct stat without checking whether thestat()call actually succeeded. POSIX leaves the buffer unspecified on failure.statFromPathzeroes it beforehand, so on platforms where a failed stat leaves the buffer untouched it reads back as "not a directory" and everything works.Where a failed stat writes into the buffer,
isDirectory()returns true for a path that doesn't exist, and the early return added in #107 then skips creation entirely.Observed on linux/amd64 under Docker Desktop emulation on Apple Silicon. minimal C reproduction gets it wrong in both directions:
Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context