Skip to content

WWSTCERT-13900 Hager Rotary dimmer, connectable - #3215

Open
JanJakubiszyn wants to merge 1 commit into
SmartThingsCommunity:mainfrom
JanJakubiszyn:Hager_waasys_rotrary_dim
Open

WWSTCERT-13900 Hager Rotary dimmer, connectable#3215
JanJakubiszyn wants to merge 1 commit into
SmartThingsCommunity:mainfrom
JanJakubiszyn:Hager_waasys_rotrary_dim

Conversation

@JanJakubiszyn

@JanJakubiszyn JanJakubiszyn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding rotary dimmer device support for Hager.

Summary of Completed Tests

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/eGM6kqdeEm2A

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

matter-switch_coverage.xml

File Coverage
All files 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/utils.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/hager/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/capability_handlers.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/attribute_handlers.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/scroll_utils/event_utils.lua 52% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/utils.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/eve_energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/scroll_handlers/event_handlers.lua 75% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_garage_door/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_mk1/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/event_handlers.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 42aff4c

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

   73 files    544 suites   0s ⏱️
3 304 tests 3 304 ✅ 0 💤 0 ❌
5 297 runs  5 297 ✅ 0 💤 0 ❌

Results for commit 42aff4c.

♻️ This comment has been updated with latest results.

@cbaumler
cbaumler requested a review from ctowns September 8, 2026 14:34
hcarter-775
hcarter-775 reviewed Sep 8, 2026
View reviewed changes
Comment thread drivers/SmartThings/matter-switch/src/sub_drivers/hager/init.lua Outdated
@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch from b9d4915 to c19f612 Compare September 9, 2026 13:02
hcarter-775
hcarter-775 reviewed Sep 9, 2026
View reviewed changes
Comment thread drivers/SmartThings/matter-switch/src/sub_drivers/hager/init.lua Outdated
@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch 2 times, most recently from 3dbca0f to 2a13db9 Compare September 14, 2026 19:55
@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch 3 times, most recently from 727237c to ecf30a4 Compare September 22, 2026 13:19
@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch 3 times, most recently from 6319ae5 to b215b96 Compare September 30, 2026 09:02
@hcarter-775

hcarter-775 commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@JanJakubiszyn, what parts of this device handling cannot function in the "main" Matter driver, as-is? Ah, is it the fact that it can switch between being on/off and level control?

@JanJakubiszyn

JanJakubiszyn commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@JanJakubiszyn, what parts of this device handling cannot function in the "main" Matter driver, as-is? Ah, is it the fact that it can switch between being on/off and level control?

Yes. that's one of the reasons. Generally it is handled in the sub_driver due to the following reasons:

  • It is possible to trigger a setting manually on the device which should create a child switch device representing a controllable status led light on the device.
  • It is possible to trigger a setting manually on the device which changes the device from a dimmable switch to ordinary switch.
  • Changes of the profiles and child creation/deletion need to be dynamic to maintain consistency.

@JanJakubiszyn JanJakubiszyn changed the title Hager rotary dimmer implementation WWSTCERT-13900 Hager Rotary dimmer, connectable Oct 2, 2026
@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch from b215b96 to 598a993 Compare October 5, 2026 06:55
@JanJakubiszyn

JanJakubiszyn commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Hello @hcarter-775 , is everything alright with this one?

@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch 2 times, most recently from c51f42c to a990ffa Compare October 8, 2026 12:31
hcarter-775
hcarter-775 approved these changes Oct 12, 2026
View reviewed changes

@hcarter-775 hcarter-775 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give a writeup of what testing was completed for this new device? Then, I think it's good to go.

@JanJakubiszyn
Hager rotary dimmer implementation
42aff4c 
# Conflicts:
#	drivers/SmartThings/matter-switch/src/test/test_hager_waasys.lua
@JanJakubiszyn
JanJakubiszyn force-pushed the Hager_waasys_rotrary_dim branch from a990ffa to 42aff4c Compare October 13, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hcarter-775 hcarter-775 hcarter-775 approved these changes
@cbaumler cbaumler Awaiting requested review from cbaumler
@ctowns ctowns Awaiting requested review from ctowns

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JanJakubiszyn @hcarter-775