[WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M by laity-w-sudo · Pull Request #3194 · SmartThingsCommunity/SmartThingsEdgeDrivers

laity-w-sudo · 2026-08-25T08:45:58Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding the air pressure function to the SNZB-02M equipment

Summary of Completed Tests

github-actions · 2026-08-25T08:46:28Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-08-25T08:46:29Z

Profile category check: ✅ Passed - all profiles have a category defined.

github-actions · 2026-08-25T08:47:06Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/qyMZQQwZPjmY

github-actions · 2026-08-25T08:48:03Z

Test Results

73 files 545 suites 0s ⏱️
3 306 tests 3 306 ✅ 0 💤 0 ❌
5 299 runs 5 299 ✅ 0 💤 0 ❌

Results for commit 0371b3b.

♻️ This comment has been updated with latest results.

github-actions · 2026-08-25T08:48:07Z

zigbee-humidity-sensor_coverage.xml

File	Coverage
All files	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/frient-sensor/air-quality/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/sonoff/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua	`96%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0371b3b

The SNZB-02M sub-driver was added but never registered, so the pressure display feature was dead code on the device. Register it via sub_drivers.lua, drop the unrelated SNZB-02LD/WD handler and utils (not in this driver, and referencing a nonexistent sub-driver), and add unit tests for pressure conversion and refresh. Co-Authored-By: Claude <noreply@anthropic.com>

cjswedes

My biggest concern is the lack of configuration for reporting the PressureMeasurement MeasuredValue attribute; has this been tested manually?

cjswedes · 2026-09-08T17:47:17Z

Is there a reason to have the nested directories? We should just add a sonoff subdriver rather than having sonoff/SNZB-02M. We want to avoid having single subdrivers for each model.

Please change the directory structure so that it is not nested, and everything falls under the sonoff directory.

KKlimczukS

@laity-w-sudo Please update Your branch.

KKlimczukS

lgtm

cbaumler · 2026-10-19T15:56:23Z

It looks like temperature, humidity, and battery reporting are not configured specifically for this model. So the default configs are used. The defaults are coarser than what's configured for the SNZB-02DR2 here. Just want to confirm this is intentional.

cbaumler · 2026-10-19T15:49:28Z

+  minimum_interval = 5,
+  maximum_interval = 3600,
+  data_type = PressureMeasurement.attributes.MeasuredValue.base_type,
+  reportable_change = 50


The PressureMeasurement.MeasuredValue attribute is in units of 0.1 kPa. So 50 means 5 kPa. Normal barometric changes are roughly 0.1–0.5 kPa per hour. So the device would almost never report on change. Can you confirm if this was tested on a real device and if this setting is desired?

cbaumler · 2026-10-19T16:03:37Z

+  device:add_configured_attribute(PRESSURE_CONFIGURATION)
+end
+
+local function refresh_handler(driver, device, command)


This handler looks redundant. I removed it locally, and the default refresh (device:refresh()) sends the same four reads: temperature, humidity, pressure (configured via add_configured_attribute) and battery percentage. The existing refresh test still passes unchanged with relaxed ordering. Could you drop refresh_handler and its capability_handlers entry unless there’s a read the default misses?

cbaumler · 2026-10-19T16:05:34Z

+  device:emit_event(capabilities.atmosphericPressureMeasurement.atmosphericPressure({value = pressure_value, unit = "kPa"}))
+end
+
+local function device_init(driver, device)


nit: A subdriver’s lifecycle_handlers.init replaces the parent’s device_init for this model instead of running alongside it. That’s harmless today, because configurations.lua has no SNZB-02M entry. If one is added later, its attributes will silently stop being configured. A one-line comment here would save the next person some debugging.

cbaumler · 2026-10-19T16:06:53Z

+local function pressure_report_handler(driver, device, value, zb_rx)
+  local pressure_value = convert_pressure_value(value.value)
+  if pressure_value == nil then
+    log.warn(string.format("SNZB-02M pressure report has no value: %s", tostring(value)))


The nil branch (log and return) has no test. Either add a small test for a report with no value, or drop the nil handling, since the framework always passes a value for this attribute.

cbaumler · 2026-10-19T16:09:36Z

+      direction = "receive",
+      message = {
+        mock_device.id,
+        PressureMeasurement.attributes.MeasuredValue:build_test_attr_report(mock_device, 960)


The only pressure test uses 960. Could you add a second case with a non-round value, such as 1013, so the division by 10 is covered more than once?

cbaumler · 2026-10-19T16:12:16Z

+  }
+)
+
+test.run_registered_tests()


I don’t see a test that covers the pressure reporting configuration, which was @cjswedes's main concern earlier in the review. Please add one that checks device_init adds the pressure configuration and that doConfigure sends the bind and configure-reporting messages for cluster 0x0403.

cjswedes · 2026-10-20T14:52:17Z

Lets remove sonoff from this profile name (and file name), so that other devices can use it if there are any others.

Add the pressure display function to SNZB-02M

1f3d8bb

laity-w-sudo force-pushed the main branch 2 times, most recently from ae161d5 to b5e3665 Compare August 25, 2026 11:23

laity-w-sudo added 3 commits August 25, 2026 20:20

Fix SNZB-02M lazy-load and pressure test

46e746d

Load-SNZB-02M-handlers-during-lazy-load

0909220

Limit-parallel-driver-tests-to-changed-drivers

1ca26b1

KKlimczukS reviewed Aug 31, 2026

View reviewed changes

KKlimczukS requested a review from cbaumler August 31, 2026 09:20

KKlimczukS changed the title ~~Add the pressure display function to SNZB-02M~~ [WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M Aug 31, 2026

cbaumler requested review from aleclorimer and cjswedes August 31, 2026 14:35

cjswedes requested changes Aug 31, 2026

View reviewed changes

Comment thread tools/run_driver_tests_p.py

KKlimczukS requested changes Sep 1, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-humidity-sensor/profiles/sonoff-humidity-temp-press-battery.yml Outdated

laity-w-sudo requested a review from KKlimczukS September 3, 2026 03:25

laity-w-sudo added 2 commits September 3, 2026 11:36

Merge branch 'SmartThingsCommunity:main' into main

7780cd9

Modify the relevant contents of SNZB-02M according to the suggestions

b7123f5

KKlimczukS reviewed Sep 3, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/test/test_sonoff_snzb02m.lua Outdated

Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/sub_drivers.lua Outdated

laity-w-sudo requested review from KKlimczukS and cjswedes September 4, 2026 02:18

Modify the relevant contents of SNZB-02M according to the suggestions

494c68c

cjswedes reviewed Sep 8, 2026

View reviewed changes

laity-w-sudo added 3 commits September 9, 2026 10:14

Merge branch 'SmartThingsCommunity:main' into main

080b525

Modify the relevant contents of SNZB-02M according to the suggestions

8285d2e

Modify the relevant contents of SNZB-02M according to the suggestions

f303440

Modify the relevant contents of SNZB-02M according to the suggestions

1cd32e1

KKlimczukS requested a review from cjswedes September 10, 2026 11:54

KKlimczukS requested changes Sep 23, 2026

View reviewed changes

KKlimczukS self-requested a review September 23, 2026 15:50

KKlimczukS approved these changes Sep 23, 2026

View reviewed changes

cjswedes reviewed Sep 23, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/test/test_sonoff_snzb02m.lua Outdated

laity-w-sudo added 2 commits October 19, 2026 10:01

Merge branch 'SmartThingsCommunity:main' into main

6b4fa30

Modify the relevant contents of SNZB-02M according to the suggestions

0371b3b

KKlimczukS requested review from KKlimczukS and cjswedes October 19, 2026 08:12

KKlimczukS approved these changes Oct 19, 2026

View reviewed changes

cbaumler reviewed Oct 19, 2026

View reviewed changes

cjswedes reviewed Oct 20, 2026

View reviewed changes

Conversation

laity-w-sudo commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjswedes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KKlimczukS left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KKlimczukS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cbaumler commented Oct 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

laity-w-sudo commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading

KKlimczukS left a comment •

edited

Loading