Repository navigation
Grow geometrically in CollectionsMarshal.SetCount - #693
Merged
Merged
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CollectionsMarshal.SetCountpolyfill (the recreated type below net5 inCollectionsMarshal.cs, and the extension for net5-net7 inCollectionsMarshalSetCount.cs) grew the list withlist.Capacity = count. That is an exact fit, so every later call that raises the count by a little reallocates and copies the whole backing array: raising the count one at a time is quadratic.Both copies now grow the way
List<T>itself does (and the way the BCLSetCountdoes throughList<T>.Grow): double the current capacity (4 when empty), capped at the maximum array length, and usecountwhen doubling is not enough. Counts, contents and the default-initialised tail are unchanged; the only observable difference isCapacity, which now matches what the BCL produces for the same calls.Measurements
net48, Release, x64, best of 3,
SetCount(list, i)fori= 1..40,000 on aList<int>:Tests
Added to
PolyfillTests_CollectionsMarshal.cs(polyfill below net8, BCL from net8):SetCount_GrowKeepsItemsAndDefaultsTheRest,SetCount_GrowFromEmpty,SetCount_GrowWithinCapacity(capacity untouched when it already fits),SetCount_ShrinkThenGrowSetCount_GrowsCapacityLikeList: pins the capacity sequence (exact fit when doubling is not enough, otherwise double, 4 from empty), which is the same on the BCLSetCount_IncrementalGrowth: 20,000 single-step increments, checking every element survives and the capacity stays within 2xSetCount_InvalidArguments