Repository navigation
Fix string.Join(char, ReadOnlySpan) stack overflow - #618
Merged
Merged
Conversation
The span overloads called the unqualified Join, which on TFMs without a polyfilled array overload bound back to the same span overload and overflowed the stack. Qualify the calls as string.Join so they reach the array overloads.
SimonCropp
force-pushed
the
fix/string-join-span-recursion
branch
from
October 12, 2026 00:27
8d51bd9 to
d44fac2
Compare
This was referenced Oct 12, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string.Join(char, ReadOnlySpan<object?>)(and theReadOnlySpan<string?>overload whenAllowUnsafeBlocksis off) called the unqualifiedJoin. On TFMs with no polyfilled array overload (netcoreapp, netstandard2.1, net5-net8) that bound back to the same span overload and killed the process with a stack overflow.The calls are now qualified as
string.Joinso they reach the array overloads. Adds a test that passes explicit spans.