Only apply AsSplitQuery in VerifyEntity when a collection is included - #1092
Merged
Merged
Conversation
VerifyEntity always wrapped the set in AsSplitQuery(). Verify.EntityFramework 16 throws for AsSplitQuery on a query that loads no collection, so every VerifyEntity<T>(id) without a collection Include failed. QuerySplitting.SplitIfIncludesCollection walks the query's Include/ThenInclude calls and only splits when one loads a collection (or uses a string path). Applied to the MSTest, NUnit, TUnit and Xunit.V3 variants.
This was referenced Sep 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VerifyEntityalways wrapped the set inAsSplitQuery(). Verify.EntityFramework 16 throws whenAsSplitQuery()is used on a query that loads no collection, so everyVerifyEntity<T>(id)without a collectionIncludefailed:QuerySplitting.SplitIfIncludesCollectionwalks the query'sInclude/ThenIncludecalls and only appliesAsSplitQuery()when one loads a collection (a stringIncludepath is assumed to be a collection). It is shared by the MSTest, NUnit, TUnit and Xunit.V3 variants.Queries that include collections still get split queries, so no snapshots change. A collection loaded only through
AutoIncludeis not detected.