Require VS Code consent for custom theme checks - #1271
Draft
aswamy wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Custom Theme Checks remain supported, but the Shopify Liquid VS Code extension now asks for explicit consent before loading JavaScript selected by a theme configuration.
require()Scope
This PR intentionally covers the VS Code path only. CLI policy and consent for other LSP clients can be considered separately. The browser extension cannot load Node custom checks and is unchanged.
Validation
pnpm build:tspnpm exec vitest --run packages/theme-check-node/src packages/theme-language-server-node/src packages/vscode-extension/src/node(91 tests)The repository-wide VS Code lint command still reports existing errors in browser globals and the existing
debuggerstatement insrc/node/server.ts; this change introduces no new lint errors.