Skip to content

Fix double-escaped cart removal labels - #3991

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/fix-double-escaped-cart-label
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:codex/fix-double-escaped-cart-label

Conversation

@efegokdemir

Copy link
Copy Markdown

Fixes #3971

Summary

Remove the redundant escape filter from cart removal labels. The t filter already escapes interpolated values for this translation, so applying escape again produces double-escaped entities in the accessible name.

Changes

  • Remove the redundant | escape from the cart items removal link.
  • Remove the redundant | escape from the cart drawer removal button.

Both changes match the existing quick-order-list-row implementation.

Validation

  • Confirmed the redundant filters are absent from both affected templates.
  • git diff --check passed.
  • Theme Check could not run locally because the Shopify CLI/Theme Check tool and a Gemfile are not available in the checkout.

@efegokdemir
efegokdemir force-pushed the codex/fix-double-escaped-cart-label branch from 67be9b8 to b0d5f6c Compare October 2, 2026 14:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cart remove link aria-label contains double-escaped HTML entities

1 participant