Repository navigation
fix(compiler): compile overloads when short backend names are occupied - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid Solidity contracts with address/integer overloads failed PQABI compilation when declarations occupied all short backend names. Allocate collision-free longer names while retaining original type resolution, ABI selectors, event/error signatures, and references inside native-call rewrites. Include a documented regression entry for crowded public, inherited, internal, free-function and array overloads.
Validation:
npm run typecheck,npm test(including build; 239 passed), and the isolated crowded-overload VM regression against shell-chain sourcee94038717a1522080ecf701edacbde21cf37b870. The VM checks full-word results, original selectors, malformed/unknown calls, overflow/empty-array panics, full-word revert/require data and rollback. Source acceptance does not imply package publication or native network activation.