Repository navigation
fix(cli): preserve nested bigint contract arguments - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI contract arguments such as
--args '[["9007199254740993n"]]'previously failed before RPC because bigint conversion applied only to the top-level array. Convert n-suffixed decimal strings recursively through arrays and named or positional tuples, including signed values. Reject unsafe JSON numeric integers before signing or sending to prevent precision loss.The existing live overload regression now executes actual CLI compile/write/read commands with fresh ML-DSA-65 and Dilithium3 keystores. It verifies the original complete ABI, full-word address and integer state, failed writes and automatic nonce/fee accounting, independent P2P import, historical queries, offline catch-up and finalized RocksDB crash recovery followed by another CLI write.
Validation:
npm run typecheckandnpm test(including the declaration build) pass. The original nested CLI failure no longer occurs; parser/ABI boundary checks cover arrays, named/positional signed tuples and rejection before transport. All ten new CLI live combinations pass against node sourcee94038717a1522080ecf701edacbde21cf37b870with RocksDB/libp2p. Genesis predeployment is explicit; native CREATE and matching public package/profile acceptance remain separate.