fix: detect nested MoE configuration - #117
Closed
Gwada wants to merge 1 commit into
Closed
Conversation
Author
|
Closing as a duplicate of #114, which covers the same nested text_config case and also supports the other expert-count key spellings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text_confignum_local_expertsbehaviorProblem
Some Hugging Face model configurations, including Qwen3.6 MoE checkpoints, store
num_expertsandnum_experts_per_tokinsidetext_config.ModelProfileronly inspected top-level fields, so these models were classified as dense. As a result, their weight size was not measured correctly and--stream-expertswas ignored.Fix
Decode the nested expert fields in
TextConfigand use them as fallbacks when the top-level values are absent. Top-level values keep priority, preserving existing behavior.Validation
The tests cover:
text_config.num_expertsandtext_config.num_experts_per_toknum_local_expertsformatRuntime validation with
lmstudio-community/Qwen3.6-35B-A3B-MLX-8bitchanged profiling from a false dense-model result to the expected MoE profile, allowing SSD expert streaming to activate.