Repository navigation
Canonicalize ShadowCode version to 0.20.0 after native merge - #2
Merged
Merged
Conversation
The native 0.20 merge left Python package metadata and the flagship version test on 0.19.0 while README and native branding already used 0.20.0. Share one canonical string across the package, desktop entry, and tests, and treat 0.19.0 as stale. Co-authored-by: Bob Corbin <ShadowfetchLinux@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Checks /
verifyjob failed onc9ccddb("Merge ShadowCode 0.20 native release into main") at.venv/bin/python -m pytest.Exactly one test failed:
tests/test_flagship_018.py::test_version_is_canonical_everywhere.That test required a single canonical version string. After the native merge, README (badge / AppImage names) and the Rust/Tauri stack advertised 0.20.0, while the Python package stayed at 0.19.0:
src/shadow_agent/__init__.py→__version__ = "0.19.0"pyproject.toml→version = "0.19.0"packaging/shadow-agent.desktop→X-ShadowCode-Version=0.19.0tests/test_flagship_018.py→CANONICAL = "0.19.0"A later main commit (
d9f2848) only split the test intoCANONICALvsNATIVE_CANONICAL. That papered over the assertion; it did not restore one shared version.Fix
Canonical version for main after the native merge is
0.20.0. That matches Cargo workspace / Tauri branding, AppImage names (ShadowCode_0.20.0_amd64.AppImage), and thev0.20.0tag already documented in README.This PR:
__version__,pyproject.toml, andX-ShadowCode-Versionto0.20.0.CANONICAL = "0.20.0"and requires that exact string in README (already present).0.19.0as stale in the flagship check, alongside older versions.0.18.0→0.19.0releases alone; they still test “newer than current,” not the package version.No native Rust/Tauri rewrite.
Local verification
python3 -m venv .venv && .venv/bin/pip install -r requirements-build.txt -e '.[dev]' && .venv/bin/python -m pytest→ 314 passed, 1 skippednpm --prefix ui test→ 8 files / 35 tests passedMerge
Please merge this for Robert, not the agent. Do not merge from this agent.