Improve Dark/Light theme toggle #25

Activity

1. deepak4566

   assigned

   ayushsgit

   on Oct 9, 2023
2. deepak4566

   added

   hacktoberfest-accepted

   on Oct 9, 2023
3. KiranPranay commented on Oct 9, 2023

   

   KiranPranay

   on Oct 9, 2023

   Member

   More actions

   I would like to improve this button so that it looks more appealing

   Yes, sure. If possible you can even try floating toggles.
   Eg,
   
4. KiranPranay

   changed the title [-]Improvement in UI[/-] [+]Improve Dark/Light theme toggle[/+] on Oct 9, 2023
5. ayushsgit commented on Oct 9, 2023

   

   ayushsgit

   on Oct 9, 2023

   Author

   More actions

   i see will try

   👍React with 👍1Reacted by devpranay
6. ayushsgit commented on Oct 9, 2023

   

   ayushsgit

   on Oct 9, 2023

   Author

   More actions

   hey i have changed the button but i am unable to deploy this site so i am unable to see the changes
   is there a way to deploy it? so i can see real time changes?
7. KiranPranay commented on Oct 9, 2023

   

   KiranPranay

   on Oct 9, 2023

   Member

   More actions

   hey i have changed the button but i am unable to deploy this site so i am unable to see the changes is there a way to deploy it? so i can see real time changes?

   You can launch in your local machine just by double tapping at index.html or use http-server, vscode live server extension etc
8. ayushsgit commented on Oct 9, 2023

   

   ayushsgit

   on Oct 9, 2023

   Author

   More actions

   https://github.com/ayushsgit/OpenCodeLaw-fork/tree/main/css
   could you integrate on your end and check it
9. KiranPranay commented on Oct 10, 2023

   

   KiranPranay

   on Oct 10, 2023

   Last edited by KiranPranay

   Member

   More actions

   https://github.com/ayushsgit/OpenCodeLaw-fork/tree/main/css could you integrate on your end and check it

   Here's your implementation.
   Screencast from 2023-10-10 11-56-01.webm

   You can even use, GitHub Codespaces to run virtually.
   Also, plz pull the latest changes. Your index.html and opencodelaw.js have conflicts.

   git fetch https://github.com/ServiceToMankind/OpenCodeLaw.git
   

   git merge 568389834708dedc47b48329b8397d0c6b9c18aa 
   
10. ayushsgit commented on Oct 10, 2023

    

    ayushsgit

    on Oct 10, 2023

    Author

    More actions

    ok working on it
11. ayushsgit commented on Oct 10, 2023

    

    ayushsgit

    on Oct 10, 2023

    Author

    More actions

    Here are the updated changes : https://splendid-llama-755d96.netlify.app/
    If you like them I would do a PR

    👍React with 👍1Reacted by devpranay
12. KiranPranay commented on Oct 11, 2023

    

    KiranPranay

    on Oct 11, 2023

    Last edited by KiranPranay

    Member

    More actions

    Here are the updated changes : https://splendid-llama-755d96.netlify.app/ If you like them I would do a PR

    To be precise, make

    .nav .slider:before {
    top : 53%;
    }
    

    Then, its good to go.
13. ayushsgit commented on Oct 11, 2023

    

    ayushsgit

    on Oct 11, 2023

    Author

    More actions

    done
    making a PR