Repository navigation
Automatic test#17802 - #26
Merged
Merged
Conversation
1. map:path series 2. map:poi series 3. map:subsite series 4. map:view series
1. map:compensation series 2. map:die series
…ntioProberDev/SentioProberControl into David.Liu/AutomaticTest#17802
…ntioProberDev/SentioProberControl into David.Liu/AutomaticTest#17802
HocaChen
approved these changes
Apr 11, 2025
beltoforion
suggested changes
Apr 15, 2025
beltoforion
left a comment
beltoforion
left a comment
Contributor
There was a problem hiding this comment.
Please reduce the size of future PR and split them into smaller chunks.
Simon1224
approved these changes
Apr 30, 2025
Removed response objects
invalid return type (should have been RoutingPriority) documentation extended
beltoforion
reviewed
May 6, 2025
beltoforion
suggested changes
May 6, 2025
beltoforion
left a comment
beltoforion
left a comment
Contributor
There was a problem hiding this comment.
I fixed a couple of minor issues
beltoforion
reviewed
May 6, 2025
Simon1224
approved these changes
May 7, 2025
1. vis:get_light_status: Change the camera parameter to CameraMountPoint. 2. Removed @deprecated from the WafermapCompensationCommandGroup. 3. map:path:add_bins / map:path:remove_bins: Modify the input to accept int, list, or range. 4. Modify the unit tests for vis:get_light_status, map:path:add_bins, and map:path:remove_bins.
1. The return value of map:get_orient_marker is changed to OrientationMarker. 2. Modify the unit tests for map:get_orient_marker. 3. Removed the print statement from test_get_bin_info().
beltoforion
reviewed
May 7, 2025
beltoforion
reviewed
May 7, 2025
beltoforion
left a comment
beltoforion
left a comment
Contributor
There was a problem hiding this comment.
All modification so far ar good.
beltoforion
reviewed
May 8, 2025
beltoforion
left a comment
beltoforion
left a comment
Contributor
There was a problem hiding this comment.
Reviewed; changes ok
- created two new command groups for setup in order to match hierarchy of the remote command - remote return values from "remote" command group functions
Enumerations should be sorted alphabetically. Otherwise the python documentation is out of order. start_show_message should return a response object
removed response return values get_access_level return value set to enumeration
enums ordered alphabetically; we need this for the documentation
beltoforion
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[python script] update the missing API for python package