Repository navigation
support for encoding added; set_chuck_site_height return values changed to mimic remote command response - #25
Merged
HocaChen merged 1 commit intoApr 10, 2025
Conversation
Added encoding parameter to connect removed unused imports modified ProberSentio.set_chuck_site_height to match remote command api. Return of a tuple instead of a response object.
beltoforion
changed the title
Simon1224
approved these changes
Apr 9, 2025
HocaChen
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add support for explicitely setting an encoding for tcp/ip connections. Right now SENTIO should be using single byte encoding by default. But the new code will use the system default encoding if none is specified. This fixes issues in the encoding of "µ" characters on the python side and opens the door for SENTIO to switch to UTF-8 in the future.
modified ProberSentio.set_chuck_site_height to match remote command api. Return of a tuple instead of a response object. Modified the api of a couple of other remote commands that were still returning a Response object despite not having a return parameter as per the remote command specification.