Skip to content

fix(claude): enable subscription login by default - #46

Merged
yaacovcorcos merged 1 commit into
mainfrom
fix/enable-claude-subscription-login
Aug 10, 2026
Merged

yaacovcorcos merged 1 commit into
mainfrom
fix/enable-claude-subscription-login

Conversation

@yaacovcorcos

Copy link
Copy Markdown
Contributor

Problem

Scient already implements Claude Code's official Claude.ai subscription flow, but a deployment environment gate hid it from normal users and made Anthropic Console the only assisted option.

Fix

  • advertise Claude subscription login by default for ordinary Claude Code configurations
  • keep Anthropic Console as the alternative and preserve external API/backend behavior
  • update focused backend and frontend tests around the existing flow
  • remove the obsolete restriction and approval language from user and internal documentation

Validation

  • 32 focused Claude provider and setup tests passed
  • vp run --filter t3 typecheck
  • vp run --filter @t3tools/web typecheck
  • changed-file lint and formatting checks
  • git diff --check
  • repository audit found no remaining restriction, approval-gate, or removed environment-variable references

Implemented with Factory Droid.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@github-actions github-actions Bot added size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 11.3 KiB 11.4 KiB +7 B (+0.1%) 15.1 KiB ✅
Codex Thread snapshot wire 5.5 KiB 5.5 KiB 0 B (0.0%) 7.3 KiB ✅
Codex Live turn WebSocket wire 5.9 KiB 5.9 KiB +7 B (+0.1%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 49.7 KiB 49.7 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 16 16 0 (0.0%) 21 ✅
Claude Total thread wire 11.3 KiB 11.4 KiB +18 B (+0.2%) 15.1 KiB ✅
Claude Thread snapshot wire 5.5 KiB 5.5 KiB +5 B (+0.1%) 7.3 KiB ✅
Claude Live turn WebSocket wire 5.8 KiB 5.9 KiB +13 B (+0.2%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 50.6 KiB 50.6 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 16 16 0 (0.0%) 21 ✅

Baseline: 245e357 · PR result: 0e1bbca · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.7 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yaacovcorcos
yaacovcorcos merged commit 3c62cc7 into main Aug 10, 2026
10 checks passed
@yaacovcorcos
yaacovcorcos deleted the fix/enable-claude-subscription-login branch August 10, 2026 13:24
yaacovcorcos added a commit to nattikahana/scient-desktop that referenced this pull request Oct 3, 2026
Replace the old line symbol with the Möbius-strip symbol from the brand kit
(ScientFactory-website assets/brand/symbol, PRs ScientFactory#42 and ScientFactory#46 there):

- In-app: scient-symbol.svg is the colour master; scient-symbol-strong.svg
  is the kit's pixel-fitted 16 px colour drawing for the 12-14 px uses.
- App icons, from the Icon Composer projects:
  - Scient: colour symbol on Scient's warm off-white tile (#FAF9F6).
  - Scient (Dev): black symbol on a white tile.
  - Nightly: white symbol on a black tile.
  iOS, universal, Windows, web and favicon renditions regenerated with
  `pnpm icons:export` (Icon Composer 27.0, design generation 26).
- macOS 1024 icons: ictool cannot export the pre-Tahoe preset, so each is
  the ictool render placed inside the previous native export's body and
  shadow (same 824 px body, 100 px inset, native shadow alpha).
- apps/desktop/resources/icon.{png,icns,ico} regenerated from the
  production icons (they still showed the February symbol).
- check-scient-brand.ts anchors now pin the new symbol for prod, dev and
  nightly.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant