Repository navigation
feat: add Scient PDF reader - #34
Merged
Merged
Conversation
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
yaacovcorcos
marked this pull request as ready for review
August 9, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User effect
Scient now opens PDFs directly in the side panel from the Files tree, file search, chat links, and other file-entry paths. The reader supports large files through byte-range loading, fast progressive search, selectable/copyable text, internal and safe external links, password-protected files, page navigation, 5% zoom controls, trackpad pinch zoom, thumbnails, outlines, and saving a copy.
This fixes the existing path where Files-tree selection treated PDFs as text and failed with
WorkspaceBinaryFileError. The server's binary-file protection remains intact.Architecture and upstream boundary
apps/web/src/scient/pdf.6.2.108and bundles its worker, support assets, and license locally.Scope
79835d70eed47265db46c950d6d07f0b5fd0dad1d45a4e3dfdcab450c4921cd140e5f2969ff97cc5Verification
pnpm --filter @t3tools/web test: 237 files / 2,116 tests passed.git diff --check, and production web build passed.Yaacov manually exercised the reader, including a very large PDF, and confirmed the general reader and improved search behavior. This remains a draft pending final manual acceptance of the last keyboard-search navigation and PDF-only browser-button removal. No browser automation, screenshot comparison, geometry testing, visual-regression testing, or automated manual acceptance was performed.
Overlap and dependencies
This PR is independently mergeable from
main. Draft PR #30 also touchesFilePreviewPanel.tsxanddocs/README.mdfor Markdown/HTML preview policy; the features are independent, but the later branch may need a small conflict resolution depending on merge order.Rollback
Revert the single feature commit. Existing non-PDF file-opening paths and the server's binary-file protection remain available independently.