Skip to content

Bump sphinx-llm>=1.0.0, exclude gallery timing page from build - #7258

Open
jacobtomlinson wants to merge 2 commits into
SciTools:mainfrom
jacobtomlinson:sphinx-llm-exclude-gallery-times
Open

Bump sphinx-llm>=1.0.0, exclude gallery timing page from build#7258
jacobtomlinson wants to merge 2 commits into
SciTools:mainfrom
jacobtomlinson:sphinx-llm-exclude-gallery-times

Conversation

@jacobtomlinson

Copy link
Copy Markdown

Description

Follow on to #7105

As of sphinx-llm>=1.0.0 you can exclude individual pages from the markdown docs build. This PR re-enables the gallery timing page and excludes it.

  • Re-enabled computation times and excluded pages
  • Bumped pins to >=1.0.0
  • Regenerated locks

@github-actions github-actions Bot added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Aug 21, 2026
@CLAassistant

CLAassistant commented Aug 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@scitools-ci scitools-ci Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templating

This PR includes changes that may be worth sharing via templating. For each file listed below, please either:

  • Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github templates/ directory. 1
  • Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
  • Dismiss the suggestion if the changes are not suitable for templating.

You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.

Template candidates

The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:

Footnotes

  1. Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
    @scitools-templating: please no update notification on: iris

@HGWright
HGWright requested a review from ESadek-MO August 26, 2026 09:38
@github-actions

Copy link
Copy Markdown
Contributor

⏱️ Performance Benchmark Report: eac21f3

Performance shifts
| Change   | Before [cefe4b78]    | After [eac21f3b]    |   Ratio | Benchmark (Parameter)   |
|----------|----------------------|---------------------|---------|-------------------------|
| -        | 87.8±0.7μs           | 62.7±0.5μs          |    0.71 | iterate.IZip.time_izip  |
| Change   | Before [cefe4b78]    | After [eac21f3b]    |    Ratio | Benchmark (Parameter)                                                          |
|----------|----------------------|---------------------|----------|--------------------------------------------------------------------------------|
| +        | 391±5μs              | 486±9μs             |     1.24 | cube.CubeCreation.time_create(False, 'instantiate')                            |
| +        | 16.6±0.2μs           | 66.3±5μs            |     4    | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')           |
| +        | 16.7±0.1μs           | 65.7±3μs            |     3.93 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')            |
| +        | 52.8±0.3μs           | 85.9±4μs            |     1.63 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')            |
| +        | 372±4ns              | 5.86±0.1ms          | 15761.1  | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50) |
| +        | 91.9±1ns             | 1.01±0.2μs          |    11.02 | save.NetcdfSave.time_netcdf_save_mesh(50, False)                               |
| +        | 94.5±2ns             | 2.68±0.2μs          |    28.31 | save.NetcdfSave.time_netcdf_save_mesh(600, False)                              |
Full benchmark results

Benchmarks that have improved:

| Change   | Before [cefe4b78]    | After [eac21f3b]    |   Ratio | Benchmark (Parameter)   |
|----------|----------------------|---------------------|---------|-------------------------|
| -        | 87.8±0.7μs           | 62.7±0.5μs          |    0.71 | iterate.IZip.time_izip  |

Benchmarks that have stayed the same:

| Change   | Before [cefe4b78]    | After [eac21f3b]    |   Ratio | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 21.0±1ms             | 23.3±2ms            |    1.11 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 52.7±0.8ms           | 53.2±3ms            |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 35.0±2ms             | 37.4±3ms            |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 165±3ms              | 165±10ms            |    1    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 23.4±1ms             | 24.3±4ms            |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 31.6±0.4ms           | 32.0±1ms            |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 23.6±2ms             | 24.0±1ms            |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 32.0±0.6ms           | 32.4±1ms            |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 21.6±2ms             | 22.0±2ms            |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 44.4±2ms             | 44.7±3ms            |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 135±2ms              | 136±5ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 135±2ms              | 135±5ms             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 21.9±2ms             | 23.1±2ms            |    1.05 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 48.2±0.6ms           | 49.1±2ms            |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 23.3±1ms             | 25.6±2ms            |    1.1  | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 58.5±2ms             | 59.7±3ms            |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 21.0±1ms             | 22.2±2ms            |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 44.6±1ms             | 46.0±3ms            |    1.03 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.08±0s              | 1.09±0.01s          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.07±0s              | 1.07±0s             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 218±3ms              | 216±7ms             |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 370±7ms              | 394±20ms            |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 22.2±1ms             | 23.5±2ms            |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 29.9±0.6ms           | 30.9±1ms            |    1.03 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 22.1±2ms             | 23.4±2ms            |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 59.1±1ms             | 59.1±2ms            |    1    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 23.1±2ms             | 24.6±2ms            |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 62.9±1ms             | 63.6±3ms            |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 23.3±2ms             | 24.6±2ms            |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 58.0±1ms             | 60.6±3ms            |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 7.70±0.03ms          | 7.78±0.08ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 22.2±0.2ms           | 22.7±0.4ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 19.3±0.3ms           | 19.8±0.3ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 125±5ms              | 126±10ms            |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 8.03±0.06ms          | 8.25±0.2ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 19.9±0.3ms           | 20.3±0.8ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 8.01±0.09ms          | 8.23±0.2ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 19.9±0.4ms           | 20.0±0.9ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 7.46±0.04ms          | 7.71±0.2ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 20.5±0.4ms           | 21.0±0.6ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 25.9±2ms             | 27.1±2ms            |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 35.2±0.7ms           | 36.1±0.6ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 7.80±0.06ms          | 7.99±0.2ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 20.8±0.3ms           | 20.8±0.6ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 8.69±0.04ms          | 9.07±0.09ms         |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 23.2±0.3ms           | 23.7±0.7ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 7.49±0.07ms          | 7.76±0.2ms          |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 20.4±0.5ms           | 20.9±0.5ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 571±0.7ms            | 571±3ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 579±0.6ms            | 584±3ms             |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 45.3±0.8ms           | 46.1±2ms            |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 138±7ms              | 137±10ms            |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 7.76±0.07ms          | 7.97±0.1ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 19.8±0.3ms           | 20.4±0.5ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 7.92±0.08ms          | 8.15±0.04ms         |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 22.7±0.5ms           | 22.4±0.9ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 7.97±0.1ms           | 8.26±0.1ms          |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 22.3±0.3ms           | 23.3±0.4ms          |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 8.10±0.1ms           | 8.29±0.06ms         |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 21.8±0.4ms           | 21.8±0.6ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 22.7±2ms             | 23.9±2ms            |    1.05 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 83.4±1ms             | 83.6±2ms            |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 22.8±1ms             | 22.9±2ms            |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 94.0±0.6ms           | 96.9±2ms            |    1.03 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 21.7±2ms             | 22.4±2ms            |    1.04 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 54.6±1ms             | 54.2±2ms            |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 8.09±0.09ms          | 8.36±0.2ms          |    1.03 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 26.7±0.7ms           | 27.4±0.7ms          |    1.03 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 8.12±0.09ms          | 8.21±0.1ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 28.3±0.6ms           | 28.9±1ms            |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 7.71±0.03ms          | 7.89±0.1ms          |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 22.0±0.4ms           | 22.1±0.6ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 204±1ms              | 207±2ms             |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 273±5ms              | 277±10ms            |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.13±0.03ms          | 1.24±0.01ms         |    1.1  | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 1.83±0.01ms          | 1.97±0.03ms         |    1.08 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 1.29±0.01ms          | 1.40±0.04ms         |    1.09 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 85.1±3ms             | 86.6±4ms            |    1.02 | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 26.4±1ms             | 26.9±1ms            |    1.02 | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 97.6±3ms             | 99.3±1ms            |    1.02 | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 87.8±2ms             | 86.9±0.7ms          |    0.99 | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 29.0±0.7ms           | 31.6±1ms            |    1.09 | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 99.1±1ms             | 102±2ms             |    1.03 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 164±6ms              | 170±10ms            |    1.03 | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 68.2±2ms             | 70.4±6ms            |    1.03 | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 194±4ms              | 197±8ms             |    1.01 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 239±7ms              | 241±8ms             |    1.01 | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 143±6ms              | 142±7ms             |    1    | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 269±5ms              | 271±10ms            |    1.01 | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 332±3μs              | 397±5μs             |    1.2  | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 860±9μs              | 874±6μs             |    1.02 | import_iris.Iris.time__concatenate                                                          |
|          | 188±3μs              | 187±5μs             |    0.99 | import_iris.Iris.time__constraints                                                          |
|          | 116±0.5μs            | 117±1μs             |    1.01 | import_iris.Iris.time__data_manager                                                         |
|          | 99.5±0.4μs           | 102±2μs             |    1.03 | import_iris.Iris.time__deprecation                                                          |
|          | 165±1μs              | 172±4μs             |    1.04 | import_iris.Iris.time__lazy_data                                                            |
|          | 979±10μs             | 994±10μs            |    1.02 | import_iris.Iris.time__merge                                                                |
|          | 73.0±0.5μs           | 75.1±0.6μs          |    1.03 | import_iris.Iris.time__representation                                                       |
|          | 629±10μs             | 622±8μs             |    0.99 | import_iris.Iris.time_analysis                                                              |
|          | 140±2μs              | 142±3μs             |    1.02 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 122±1μs              | 125±1μs             |    1.03 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 255±3μs              | 253±2μs             |    0.99 | import_iris.Iris.time_analysis__interpolation                                               |
|          | 188±3μs              | 191±2μs             |    1.01 | import_iris.Iris.time_analysis__regrid                                                      |
|          | 110±1μs              | 109±0.5μs           |    0.99 | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 141±2μs              | 143±2μs             |    1.02 | import_iris.Iris.time_analysis_calculus                                                     |
|          | 336±2μs              | 337±3μs             |    1    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 91.7±0.9μs           | 91.5±0.8μs          |    1    | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 210±2μs              | 208±2μs             |    0.99 | import_iris.Iris.time_analysis_maths                                                        |
|          | 94.1±0.2μs           | 95.4±0.8μs          |    1.01 | import_iris.Iris.time_analysis_stats                                                        |
|          | 173±2μs              | 171±3μs             |    0.98 | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 321±4μs              | 317±3μs             |    0.99 | import_iris.Iris.time_aux_factory                                                           |
|          | 80.5±0.5μs           | 82.2±0.9μs          |    1.02 | import_iris.Iris.time_common                                                                |
|          | 164±2μs              | 164±3μs             |    1    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.57±0.02ms          | 1.59±0.02ms         |    1.01 | import_iris.Iris.time_common_metadata                                                       |
|          | 183±3μs              | 179±2μs             |    0.98 | import_iris.Iris.time_common_mixin                                                          |
|          | 1.18±0ms             | 1.19±0.01ms         |    1.01 | import_iris.Iris.time_common_resolve                                                        |
|          | 258±4μs              | 257±3μs             |    1    | import_iris.Iris.time_config                                                                |
|          | 134±1μs              | 137±3μs             |    1.02 | import_iris.Iris.time_coord_categorisation                                                  |
|          | 386±5μs              | 382±5μs             |    0.99 | import_iris.Iris.time_coord_systems                                                         |
|          | 836±10μs             | 836±20μs            |    1    | import_iris.Iris.time_coords                                                                |
|          | 781±30μs             | 741±20μs            |    0.95 | import_iris.Iris.time_cube                                                                  |
|          | 265±2μs              | 263±2μs             |    0.99 | import_iris.Iris.time_exceptions                                                            |
|          | 73.9±0.8μs           | 74.1±0.3μs          |    1    | import_iris.Iris.time_experimental                                                          |
|          | 191±0.9μs            | 194±2μs             |    1.02 | import_iris.Iris.time_fileformats                                                           |
|          | 261±5μs              | 256±1μs             |    0.98 | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.65±0.03ms          | 2.62±0.01ms         |    0.99 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 75.4±0.2μs           | 77.2±0.7μs          |    1.02 | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 115±2μs              | 115±2μs             |    0.99 | import_iris.Iris.time_fileformats_abf                                                       |
|          | 447±8μs              | 437±5μs             |    0.98 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.73±0.2ms           | 4.60±0.07ms         |    0.97 | import_iris.Iris.time_fileformats_dot                                                       |
|          | 71.4±0.4μs           | 72.3±1μs            |    1.01 | import_iris.Iris.time_fileformats_name                                                      |
|          | 257±4μs              | 253±1μs             |    0.98 | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 115±1μs              | 116±1μs             |    1.01 | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 159±2μs              | 160±2μs             |    1.01 | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 317±3μs              | 315±4μs             |    0.99 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 816±8μs              | 806±6μs             |    0.99 | import_iris.Iris.time_fileformats_pp                                                        |
|          | 175±2μs              | 177±2μs             |    1.01 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 132±0.6μs            | 132±2μs             |    0.99 | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 577±6μs              | 583±7μs             |    1.01 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 228±2μs              | 231±9μs             |    1.01 | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 80.7±0.3μs           | 82.7±1μs            |    1.02 | import_iris.Iris.time_fileformats_um                                                        |
|          | 159±2μs              | 158±3μs             |    0.99 | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 138±3μs              | 138±1μs             |    1    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 72.2±0.6μs           | 72.7±0.5μs          |    1.01 | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 78.8±0.7μs           | 79.6±0.8μs          |    1.01 | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 975±7μs              | 964±8μs             |    0.99 | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 145±1μs              | 145±2μs             |    1.01 | import_iris.Iris.time_io                                                                    |
|          | 182±4μs              | 181±3μs             |    0.99 | import_iris.Iris.time_io_format_picker                                                      |
|          | 205±3μs              | 205±2μs             |    1    | import_iris.Iris.time_iris                                                                  |
|          | 128±2μs              | 129±0.8μs           |    1.01 | import_iris.Iris.time_iterate                                                               |
|          | 34.5±0.1ms           | 34.7±0.5ms          |    1.01 | import_iris.Iris.time_palette                                                               |
|          | 1.90±0.1ms           | 1.89±0.06ms         |    0.99 | import_iris.Iris.time_plot                                                                  |
|          | 282±30μs             | 285±20μs            |    1.01 | import_iris.Iris.time_quickplot                                                             |
|          | 2.24±0.04ms          | 2.15±0.04ms         |    0.96 | import_iris.Iris.time_std_names                                                             |
|          | 1.88±0.01ms          | 1.88±0.01ms         |    1    | import_iris.Iris.time_symbols                                                               |
|          | 106±10ms             | 105±10ms            |    0.99 | import_iris.Iris.time_tests                                                                 |
|          | 234±1μs              | 256±5μs             |    1.09 | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 5.13±0.1ms           | 5.01±0.04ms         |    0.98 | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 122±0.6μs            | 123±0.6μs           |    1.01 | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.59±0.03ms          | 2.56±0.02ms         |    0.99 | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 538±4μs              | 532±10μs            |    0.99 | import_iris.Iris.time_third_party_numpy                                                     |
|          | 175±2μs              | 176±1μs             |    1.01 | import_iris.Iris.time_third_party_scipy                                                     |
|          | 101±1μs              | 101±0.7μs           |    0.99 | import_iris.Iris.time_time                                                                  |
|          | 852±10μs             | 853±10μs            |    1    | import_iris.Iris.time_util                                                                  |
|          | 9.85±0.03ms          | 9.92±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 17.5±0.6ms           | 16.6±0.7ms          |    0.95 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 9.76±0.04ms          | 9.97±0.2ms          |    1.02 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 9.90±0.09ms          | 10.1±0.1ms          |    1.02 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 14.2±0.3ms           | 14.2±0.09ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 9.77±0.08ms          | 9.90±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.49±0s              | 1.51±0.02s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 12.8±0.2ms           | 13.1±0.4ms          |    1.02 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.49±0.01s           | 1.50±0.03s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.50±0.01s           | 1.50±0.02s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 13.0±0.4ms           | 13.3±0.4ms          |    1.02 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.47±0.01s           | 1.53±0.03s          |    1.04 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.21±0.2ms           | 5.24±0.03ms         |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 13.0±0.3ms           | 12.9±0.2ms          |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.11±0.02ms          | 5.08±0.07ms         |    0.99 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.28±0.02ms          | 5.25±0.2ms          |    0.99 | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 12.7±0.1ms           | 12.9±0.2ms          |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.11±0.03ms          | 5.07±0.03ms         |    0.99 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 24.0±1ms             | 23.7±1ms            |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 21.9±0.7ms           | 22.6±0.7ms          |    1.03 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 13.3±0.8ms           | 13.2±1ms            |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 28.5±1ms             | 29.2±2ms            |    1.03 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 83.3±0.9ms           | 72.5±0.7ms          |    0.87 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 28.8±1ms             | 29.1±1ms            |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 654±8ms              | 665±10ms            |    1.02 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 3.53±0.06ms          | 3.86±0.2ms          |    1.1  | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 648±5ms              | 667±7ms             |    1.03 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 646±6ms              | 663±9ms             |    1.03 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.59±0.1ms           | 3.88±0.1ms          |    1.08 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 639±6ms              | 656±10ms            |    1.03 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 2.25±0.04ms          | 2.37±0.09ms         |    1.05 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 3.59±0.09ms          | 3.76±0.3ms          |    1.05 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 2.23±0.04ms          | 2.31±0.06ms         |    1.04 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 2.32±0.06ms          | 2.35±0.06ms         |    1.01 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.57±0.07ms          | 3.89±0.1ms          |    1.09 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 2.29±0.09ms          | 2.28±0.03ms         |    1    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 362±2ms              | 371±4ms             |    1.02 | load.ManyCubes.time_many_cube_load                                                          |
|          | 93.3±0.6ms           | 96.1±1ms            |    1.03 | load.ManyVars.time_many_var_load                                                            |
|          | 9.97±0.08ms          | 10.1±0.2ms          |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 9.93±0.07ms          | 9.98±0.1ms          |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.52±0.02s           | 1.53±0.02s          |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.51±0.01s           | 1.51±0.02s          |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.25±0.05ms          | 5.29±0.03ms         |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.12±0.06ms          | 5.09±0.03ms         |    0.99 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.18±0.1ms           | 9.03±0.03ms         |    0.98 | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 5.60±0.05ms          | 5.60±0.05ms         |    1    | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.49±0.01s           | 1.51±0.01s          |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 432±6ms              | 427±7ms             |    0.99 | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.39±0.02ms          | 4.43±0.03ms         |    1.01 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.25±0.03ms          | 4.24±0.05ms         |    1    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 154±3ms              | 160±3ms             |    1.04 | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 16.1±0.5ms           | 15.7±1ms            |    0.97 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 153±2ms              | 155±3ms             |    1.01 | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 31.1±0.2ms           | 31.9±0.1ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 15.3±0.4ms           | 15.7±0.1ms          |    1.03 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 30.7±0.2ms           | 31.4±0.3ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 21.1±1ms             | 20.3±0.4ms          |    0.96 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 51.2±3ms             | 52.0±0.8ms          |    1.02 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 10.1±0.6ms           | 10.1±0.2ms          |    1    | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 17.7±2ms             | 18.7±0.6ms          |    1.06 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 20.4±1ms             | 21.2±1ms            |    1.04 | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 20.6±0.8ms           | 21.9±0.7ms          |    1.06 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 10.1±0.5ms           | 10.2±0.5ms          |    1    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 12.8±1ms             | 13.3±0.4ms          |    1.04 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 22.2±0.9ms           | 22.8±0.4ms          |    1.03 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 63.7±3ms             | 63.3±2ms            |    0.99 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 22.0±1ms             | 23.1±1ms            |    1.05 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 24.2±1ms             | 24.3±0.3ms          |    1    | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 4.02±0.2ms           | 3.92±0.1ms          |    0.97 | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 4.87±0.5ms           | 5.03±0.1ms          |    1.03 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 48.2±6ms             | 52.4±2ms            |    1.09 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 1.09±0.04s           | 1.10±0.02s          |    1.01 | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 1.14±0.02s           | 1.16±0.01s          |    1.01 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 444±4ms              | 455±7ms             |    1.02 | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 2.21±0G              | 2.21±0G             |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 71.7±4M              | 71.7±4M             |    1    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 38.9±3ms             | 36.4±1ms            |    0.94 | merge_concat.Merge.time_merge                                                               |
|          | 126±0.03M            | 126±0.03M           |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 159±2ms              | 147±2ms             |    0.93 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 769±3k               | 769±3k              |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.2±0M              | 60.2±0M             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 19.0±0.4ms           | 19.1±0.2ms          |    1.01 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 22.4±0.4ms           | 22.7±0.4ms          |    1.01 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 821±2k               | 821±2k              |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 24.6±0M              | 24.6±0M             |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 113±3ms              | 116±3ms             |    1.03 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 426±9ms              | 412±6ms             |    0.97 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.5±0.05M            | 1.48±0.05M          |    0.98 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.5±0.05M           | 96.5±0.09M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 76.7±3ms             | 76.0±0.8ms          |    0.99 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 375±7ms              | 370±5ms             |    0.99 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.37±0.04M           | 1.37±0.03M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.4±0.03M           | 96.4±0.03M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.175361             | 2.175361            |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01536099999998   | 216.01536099999998  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.50±0.3ms           | 6.55±0.2ms          |    1.01 | plot.AuxSort.time_aux_sort                                                                  |
|          | 56.8±3ms             | 57.8±1ms            |    1.02 | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 104±6ms              | 102±7ms             |    0.98 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 56.8±2ms             | 59.9±2ms            |    1.05 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 107±0.1M             | 107±0.09M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.03M            | 147±0.03M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.66±0.02ms          | 4.83±0.05ms         |    1.04 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 79.3±1ms             | 84.0±3ms            |    1.06 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 21.4±0.7ms           | 22.6±3ms            |    1.06 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 296±2ms              | 298±6ms             |    1    | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 62.5±2ms             | 64.5±3ms            |    1.03 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 264±4ms              | 266±6ms             |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 31.5±1k              | 31.5±1k             |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.84±0.1M            | 1.84±0.2M           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 31.5±1k              | 31.4±1k             |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 191±20M              | 191±30M             |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 41.1±0.6ms           | 41.7±0.5ms          |    1.01 | stats.PearsonR.time_lazy                                                                    |
|          | 9.53±0.4ms           | 10.2±0.5ms          |    1.07 | stats.PearsonR.time_real                                                                    |
|          | 29±0.7M              | 29.8±0.4M           |    1.03 | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.3±0M              | 18.3±0M             |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 25.0±0.7ms           | 25.7±2ms            |    1.03 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 79.8±1ms             | 82.4±2ms            |    1.03 | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 17.6±0.01M           | 17.6±0.01M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 7.74±0.01M           | 7.74±0.01M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Benchmarks that have got worse:

| Change   | Before [cefe4b78]    | After [eac21f3b]    |    Ratio | Benchmark (Parameter)                                                          |
|----------|----------------------|---------------------|----------|--------------------------------------------------------------------------------|
| +        | 391±5μs              | 486±9μs             |     1.24 | cube.CubeCreation.time_create(False, 'instantiate')                            |
| +        | 16.6±0.2μs           | 66.3±5μs            |     4    | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')           |
| +        | 16.7±0.1μs           | 65.7±3μs            |     3.93 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')            |
| +        | 52.8±0.3μs           | 85.9±4μs            |     1.63 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')            |
| +        | 372±4ns              | 5.86±0.1ms          | 15761.1  | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50) |
| +        | 91.9±1ns             | 1.01±0.2μs          |    11.02 | save.NetcdfSave.time_netcdf_save_mesh(50, False)                               |
| +        | 94.5±2ns             | 2.68±0.2μs          |    28.31 | save.NetcdfSave.time_netcdf_save_mesh(600, False)                              |

Generated by GHA run 32474119556

@ESadek-MO

Copy link
Copy Markdown
Contributor

Hi Jacob,

We've currently got a number of failures in our lockfiles, which we're currently investigating -#7243 .
Hopefully, once we've fixed those, it will also fix your PR Failures and we can get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants