Repository navigation
fix: respect local cache deletion patterns - #146
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncLocalCache.delete_missingacceptsscan_patternbut ignores it. A scoped cleanup such asdelete_missing([], scan_pattern="flags:*")therefore also deletes company entries and other namespaces. The datastream flags handler already uses this scoped call; the Redis provider filters deletion by the supplied pattern.Restrict deletion candidates using case-sensitive pattern matching, then preserve keys in the keep list. Unscoped and wildcard cleanup retain their previous behavior. Six deterministic public-cache cases cover scoped deletion with and without a retained flag, company-only cleanup, an unmatched prefix, case sensitivity, and the unscoped controls. One unchanged cache-comprehension expression is reformatted by the pinned formatter. Only handwritten
.fernignore-protected code and custom tests change.Validation with Python 3.10.20, Poetry 2.1.4, unchanged poetry.lock and CI's datastream/aiohttp extras:
Open reconnect-cache PR #128 changes reconnect invalidation and does not modify this local cache implementation. The scoped deletion bug is separate. No generated bindings, dependencies, versions or release configuration are changed.