Fix string literal parsing inside expressions

[SayanthRock]

User description

Currently normalize_expression incorrectly rewrites parts of string literals such as mutating operators == or != and stripping numeric separators _. This change modifies the internal SQL AST compiler behavior so that string literals are faithfully preserved during SQL code generation without stripping arbitrary underscores inside strings. It includes tests to verify this logic on expressions like message == "user_1_000 == active !=".

---

PR created automatically by Jules for task 16471239715463804580 started by @SayanthRock

---

CodeAnt-AI Description

Preserve string contents when generating SQL from expressions

What Changed

• String values now retain underscores, comparison operators, and keywords exactly as entered
• Comparison operators outside strings are still converted to valid SQL syntax
• Numeric separators in expressions are normalized without altering text inside quoted values
• Added coverage for strings containing numeric separators and operators

Impact

✅ Accurate string matching in generated SQL
✅ Fewer unexpected query results
✅ Reliable handling of quoted filter values

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

• Bug Fixes
  • Improved query normalization for numeric separators, comparison operators, and keywords.
  • Preserved quoted text exactly as entered, including operators, underscores, and numeric separators within quotes.
  • Improved consistency when processing expressions that use equivalent operator formats such as != and ==.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	0c87771	Aug 05, 2026 · 09:58	10:00

[ai-coding-guardrails]

You've hit your review limit for the week, but don't worry you'll get some more next week!

Contact us at hello@zenable.io if you want this rate limit to go away

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

📝 Walkthrough

Walkthrough

normalize_expression now performs quote-aware numeric-separator removal, operator normalization, and keyword normalization in one scan. Quoted strings remain unchanged. A regression test covers operators and numeric separators inside quoted filter text.

Changes

Expression normalization

Layer / File(s)	Summary
Quote-aware normalization and regression coverage compiler/rockql-sql/src/lib.rs	The scanner normalizes !=, ==, keywords, and numeric separators outside quotes. Quoted text remains unchanged. A regression test verifies this behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preserving string literals during expression parsing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-string-literal-normalization-16471239715463804580

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@compiler/rockql-sql/src/lib.rs`:
- Around line 196-205: Update the underscore handling in the tokenizer branch
around is_numeric_separator so the separator is skipped only when every
preceding character in word is an ASCII digit, while preserving the existing
adjacent-digit checks; otherwise append the underscore to the token. Add a
regression test covering an identifier such as user1_000 and verify it remains
unchanged through SQL generation.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f9e939d0-a05e-4bd8-b0ec-8293b009bd3e

📥 Commits

Reviewing files that changed from the base of the PR and between 87532a0 and 0c87771.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• compiler/rockql-sql/src/lib.rs

[ai-coding-guardrails]

You've hit your review limit for the week, but don't worry you'll get some more next week!

Contact us at hello@zenable.io if you want this rate limit to go away