Repository navigation
Copilot PR suggestion - std::bind #4
Description
Using std::bind with perfect forwarding may not preserve the value category correctly in all cases. Modern C++ best practices recommend using lambdas instead of std::bind for better type safety and performance. Consider replacing std::bind with a lambda: f = std::forward(F), ...args = std::forward(ArgList) mutable { return f(args...); }. This approach is clearer, potentially more efficient, and handles forwarding more predictably.
std::shared_ptr<std::packaged_task<ReturnType()>> task = std::make_shared<std::packaged_task<ReturnType()>>((
std::bind(std::forward<Function>(F),
std::forward<Args>(ArgList)...)
));
auto task = std::make_shared<std::packaged_task<ReturnType()>>(
[f = std::forward<Function>(F), ...args = std::forward<Args>(ArgList)]() mutable {
return std::invoke(f, args...);
}
);
Activity