Skip to content

Fix storing user and pass in client cfg - #4

Merged
IrishDarkshadow merged 3 commits into
SWG-Source:masterfrom
AconiteX:master
Sep 14, 2020
Merged

Fix storing user and pass in client cfg#4
IrishDarkshadow merged 3 commits into
SWG-Source:masterfrom
AconiteX:master

Conversation

@AconiteX

Copy link
Copy Markdown
Member

This enables the ability to store your account credentials locally thereby enabling auto-login so you don't have to type in your username or password every time you launch the client and instead you land directly on the character creation screen.

I imagine this was removed when SOE enabled sessions from the station launchpad but don't see any reason for it to not exist now.

The following goes in your client-side cfg for this to work:

loginClientID=username
loginClientPassword=yourpassword
autoConnectToLoginServer=true

@AconiteX

Copy link
Copy Markdown
Member Author

Added fa9e0af to this which has a few more conversation editor script writer fixes

@IrishDarkshadow
IrishDarkshadow merged commit 896f992 into SWG-Source:master Sep 14, 2020
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 14, 2026
… node_errors)

Surgical in-place revision of the four Phase-28 plans + CONTEXT to close the
Codex+Cursor consensus findings (REVIEWS.md):

- SWG-Source#1 28-03: rewrite merge loop to single descending pass; claimed/tombstoned
  guard BEFORE the tree-length-0 branch; delete claimed.pop (the un-claim bug)
- SWG-Source#2 28-04: add test_searchtree_lower_priority_length0_does_not_tombstone_winner
- SWG-Source#3 28-04: mandatory build_cot2000() + read_cot2000_entries round-trip (drop
  the detector-only hedge); SC#1 met literally, no ROADMAP wording change
- SWG-Source#4 28-04: strengthen integration test (assert priority-10 winner_node.kind==
  'path' when override non-empty); real-archive tombstone proof delegated to the
  synthetic suite — SC#3 tombstone clause narrowed to synthetic, override on real
- SWG-Source#5 28-02: verified vendored dataclasses already expose snake_case length +
  compressed_length; verbatim+two-edits stands; +extended-stride 8-byte pad note
- SWG-Source#6 28-02/03/04: soften 02 bounded-reads wording; add merge-boundary bounds
  preflight (T-28-03-04) + regression test
- SWG-Source#7 28-03/04: deterministic sorted os.walk, followlinks=False, reparse/junction
  skip; +missing/empty searchPath dir tests
- SWG-Source#8 28-03/04: add VirtualTree.node_errors diagnostics field + assertions
- SWG-Source#9 28-CONTEXT: correct blanket length-0-tombstone line to per-node-type nuance
- LOW: 28-01 pin .python-version to 3.11 floor; 28-03 scanner _NN_/TOCTreePath
  engine-role notes

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 14, 2026
…st-hit-wins merge

- fix_up_file_name VERBATIM engine port (leading-.. only; keeps interior .. — review SWG-Source#3)
- safe_virtual_key hardening wrapper rejects interior-../drive/UNC/empty (threat T-28-03-01)
- single descending pass first-hit-wins; guard precedes tree-length-0 branch (review SWG-Source#1, no claimed.pop)
- PER-NODE-TYPE tombstone: tree length-0 = global remove; toc length-0/offset-0 = skip-only
- shadowed = later REAL copies only, excludes tombstones/absent (review SWG-Source#4)
- eager deterministic searchPath os.walk with reparse-dir prune before descent (Open-Q1, review SWG-Source#5/SWG-Source#7)
- .tre AND .toc header bounds preflight + count*stride cap (review SWG-Source#6/#2a, threat T-28-03-04)
- node_errors diagnostics field on VirtualTree (review SWG-Source#8); documented approximation boundary (review SWG-Source#7)
- re-export fix_up_file_name/safe_virtual_key/build_virtual_tree/MergedEntry/VirtualTree from __init__
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 17, 2026
…ope TU manifest

- Add src/build/win32/x64-scratch/ to .gitignore (D-01 signal-generator,
  not a deliverable; keeps committed swg.sln/.vcxproj 32-bit-only for Phase 33)
- Scratch dir holds gen-manifest.sh + in-scope-tus.txt (2216 TUs, 57 in-scope
  libs) mechanically derived from every in-scope lib's ClCompile graph
  (review SWG-Source#4: exhaustive, not a hand-picked first cut); all 18 known-defect
  TUs present as a subset; editor/tool/3rd-party/server libs excluded (D-03)
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 17, 2026
…class-(B) gap

Task 1 of the phase gate: ran the FIRST full -Scope all scratch x64 sweep
(2217 in-scope TUs) and wrote 31-PHASE33-RESIDUAL-WORKLIST.md with the (A)/(B)
classification (review SWG-Source#4) + named runtime residuals (DebugHelp walk/Rip, SSE
align, FPU door-snap) + N1 harness-deletion coverage hole + N2 C4267 carry-forward.

CRITICAL: the full sweep surfaced NEW class-(B) in-scope boot-path escapes the
wave-2 substring-filtered sweeps never compiled (13 __asm C4235, ~8 genuine
C4311/C4312, 2-3 time_t width-movers). Per review SWG-Source#4 + the plan-06 Task 1
acceptance these are NOT deferrable to Phase 33 — flagged for a Phase-31
gap-closure plan (RESIDUAL-31-06 blocker in STATE.md, B-GAP section in the
worklist). The 80 C4244 are D-07-excluded container-count + STL noise
(codex-validated). Plan-06 Task 2/3 BLOCKED until gap closure.
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 17, 2026
…6 full sweep

Authored after plan 31-06's first full -Scope all sweep surfaced ~12 in-scope
boot-path TUs the wave-2 substring-filtered sweeps never compiled (review SWG-Source#4:
class-(B) escapes MUST be fixed in Phase 31, not deferred to Phase 33).
Covers 31-PHASE33-RESIDUAL-WORKLIST.md (B-GAP-1/2/3): 13 __asm survivors,
~8 ptr-truncations (incl. PathSearch UAF + StatusWindow this-truncation +
VoidBindSecond shared-header), 2-3 time_t audits. User-authorized (Option A).
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 17, 2026
…s + 3 up-front audits

- Direct3d9_VertexShaderData.cpp: D3DXCompileShader -> D3DCompile via ABI-identical
  reinterpret-cast at the call boundary; flags = D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY
  ONLY (NO PACK_MATRIX_ROW_MAJOR -- review fix SWG-Source#4); applyToMainSource on m_compileText
- Fix-A SEH guard RETAINED (D-04): compileVertexShaderFpGuarded now wraps D3DCompile
  (belt-and-suspenders until Wave-2/32-05 retires it)
- include-cache rewrite-BEFORE-insert (Cursor C2): Include ctor applies applyToIncludeBuffer
  so REWRITTEN bytes are cached; 2nd #include returns rewritten text. Viewer/tool path
  rewrites on Open too
- vs_1_1 branch handled (review fix SWG-Source#5 / D-06): promote to vs_2_0 + DEBUG_FATAL; D3DCompile
  dropped vs_1_1, never silently null a VS
- DECLARE_textureCoordinateSets register omission BOTH places (review fix SWG-Source#7 / Cursor C5):
  engine macro strips ' : register(vN)'; all 9 stage/override/*.vsh DECLARE macros lose the
  post-preprocessor ': register(vN)' leak (incl. tfcl_4uv's 4x). InputVertex struct bindings
  retained (Rules B/C handle those pre-preprocessor)
- Direct3d9_HlslRewrite.cpp: [Rule 3 fix] close the anonymous namespace before the public
  function defs (the WIP file left it open -> C2888/C1075; never built before this plan)
- Task-2(G) THREE up-front audits (hlsl-constant-audit.txt): (i) PASS Rule D disabled
  (15 flat register(cN) + 8 native register(bN), no cbuffer/packoffset); (ii) v# input
  signature -- D3DCompile re-numbers v# but PRESERVES dcl usage semantics; D3D9 binds by
  D3DDECLUSAGE+UsageIndex (VertexDeclarationMap.cpp:128-223) NOT raw v#, so Cursor C1
  'renders garbage' is REFUTED (pending render confirmation); (iii) PASS flag audit
- 5-target Debug build clean (incl. gl11): 0 unresolved external symbol, 0 LNK1181, 0 error C
- asm path (:567 D3DXAssembleShader) untouched (D-04); d3dx9.lib retained (D-05)
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jun 21, 2026
…ame-time clamp (SWG-Source#4)

Persist the validated tuning into the tracked cfg template (the staged stage/*.cfg are
gitignored): [SharedFoundation] minFrameRate=10 (CONSULT-45 SWG-Source#4 -- clamp the per-frame step so
a load hitch can't snap the camera) and [ClientGame/ClientInteriorLayoutManager]
maxInteriorCreatesPerFrame=10 (CONSULT-46 SWG-Source#2 -- spread the interior-layout create burst).
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Jul 20, 2026
… template re-point (SWG-Toolkit change request SWG-Source#4; model-D lossless rebind)

Their CONSULT-70 caught the data-loss: remove+re-add rebind tombstones the
building's whole authored subtree and churns the id. New row swaps ONLY the
node's OTNL template-name index (internObjectTemplateName extracted public
from addObject; append-only, no layout change). Fail-closed: authored
non-buildout nodes, TreeFile-resolvable name (forgetMissingFile first --
the just-written-derived-.iff negcache trap). Data-only; reload spawns from
the derived template; pob-crc guard still fails loudly at spawn.
Contract 144 -> 145. Utinni SUNSET: SWG-Toolkit is the sole consumer.

Gates: forced relink 0 unresolved / 0 errors, ord-82 export, 145==145,
45s boot smoke clean, exe restaged.
kennethlong added a commit to kennethlong/client-tools that referenced this pull request Aug 15, 2026
…sumer x64 change request

Answers asks SWG-Source#4 and SWG-Source#5 of the toolkit 2026-08-15 x64 CHANGE-REQUEST (the
other four were satisfied by the x64 port itself; full answers in the
PROVIDER-HANDBACK). 160 -> 162 names, both arches from the one source:

client::advertisedArchBits -- extern "C" int __cdecl (void), the provider
pointer width in bits (32/64), compile-time per-arch. The consumer arch
assert: their export-absent fallback seeds x86 SWGEmu RVA literals and no
legacy x64 client exists, so their x64 agent fails closed on a missing
export -- and with this row asserts the table IS the x64 contract instead
of inferring it from the PE header.

object::setScale -- &Object::setScale via pmfToVoid (non-virtual,
out-of-line, Object.h:228 / Object.cpp:2205; Vector is a 3-float POD by
const&, the setPosition_w boundary shape). Closes the consumer D-09 gap
their rva_table deliberately seeds nullptr for.

Version 33 -> 34 per the name-add policy; the bump also serves as the
dual-arch-contract signal the consumer requested (they treat version
drift as a soft warning, so the x86 path is unaffected).

Verified: 5-target Release both platforms, 0 unresolved externals;
tools/hookpoints-probe on both staged exes: version=34 count=162 nulls=0
dups=0.
swgsais added a commit to Galaxies-Reborn/client-tools that referenced this pull request Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants