Skip to content

Creation of STIXCIQIdentity3_0 and its children entities does not emit the "Entity.created.from_obj" signal #356

Description

@stevefranchak

It appears that the from_obj method of the STIXCIQIdentity3_0 class and classes for child nodes of stix-ciqidentity:Specification do not call up to mixbox.entities.Entity.from_obj. mixbox.entities.Entity.from_obj emits a Entity.created.from_obj signal. stixmarx.parser.MarkingParser creates its set of entities to use for processing by subscribing its _handle_entity_created callback to the Entity.created.from_obj signal. As a result, since this signal is not sent for any entities of and including stix-ciqidentity:Specification, these entities are not marked by stixmarx. I'm creating this as an issue against python-stix because the CIQIdentity3_0Instance implementation is contained in this project.

Activity

  1. emmanvg commented on Oct 5, 2018

    @emmanvg
    Contributor

    Hi @stevefranchak!

    Thanks for reporting this. It appears the markings don't get applied to this extension because their children need binding objects and new API objects that implement the new TypedField changes. Thus, any CIQIdentity3_0Instance children would not be captured by stixmarx and will not be marked.

  2. stevefranchak commented on Oct 5, 2018

    @stevefranchak
    Author

    Thanks for responding, @emmanvg!

    Is this something that your team is planning on updating? I could try figuring it out but wanted to check with you first. (And I'll make sure to include tests this time - that was my bad.)

  3. emmanvg commented on Oct 5, 2018

    @emmanvg
    Contributor

    @stevefranchak, unfortunately we don't see this as being high priority; instead we are focusing most of our efforts towards STIX 2. I would certainly appreciate a PR if you or anyone is willing to extend the current functionality.

    Keep in mind stix-ciqidentity:CIQIdentity3_0Instance extension leverages the CIQ Specification which is extensive. Here is a link to the XSD schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions