Skip to content

AttributeError: 'list' object has no attribute 'isoformat' #350

Closed
Closed
AttributeError: 'list' object has no attribute 'isoformat'#350

Description

@ajnovice
ajnovice
opened on May 24, 2018

instance.stix_xml = package.to_xml()
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/stix/base.py", line 141, in to_xml
obj = self.to_obj(ns_info=ns_info if auto_namespace else None)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 300, in to_obj
val = [_objectify(field, x, ns_info) for x in val]
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 300, in
val = [_objectify(field, x, ns_info) for x in val]
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/cybox/common/object_properties.py", line 87, in to_obj
obj = super(ObjectProperties, self).to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 32, in _objectify
return value.to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/cybox/common/properties.py", line 204, in to_obj
attr_obj = super(BaseProperty, self).to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/cybox/common/attribute_groups.py", line 73, in to_obj
obj = super(PatternFieldGroup, self).to_obj(ns_info=ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 304, in to_obj
val = _objectify(field, val, ns_info)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/entities.py", line 33, in _objectify
return field.binding_value(value)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/fields.py", line 365, in binding_value
return serialize_datetime(value)
File "/home/ubuntu/ctix-2/venv/lib/python3.5/site-packages/mixbox/dates.py", line 41, in serialize_datetime
return value.isoformat()
AttributeError: 'list' object has no attribute 'isoformat'

date(its a field in EmailHeader of EmailMessage) is of type DateTime which has value of list type.

Activity

  1. gtback commented on May 24, 2018

    @gtback
    gtback
    on May 24, 2018
    Contributor

    Hi @ajnovice . Can you provide a sample STIX Package (or code to create the package) that demonstrates this problem. If I understand correctly, it may be as simple as "if the value is a list, call isoformat on every item in the list rather than on the list itself", but want to make sure I'm solving the problem in the right place. Thanks!

  2. ajnovice commented on May 26, 2018

    @ajnovice
    ajnovice
    on May 26, 2018
    Author

    Below is the code of DateTime class.As we can see value is of ListDateTimeField

    class DateTime(BaseProperty):
    _binding_class = common_binding.DateTimeObjectPropertyType
    default_datatype = "dateTime"

    value = ListDateTimeField("valueOf_", key_name="value")
    precision = fields.TypedField("precision", preset_hook=validate_datetime_precision)

    def __init__(self, value=None, precision='second'):
        super(DateTime, self).__init__(value=value)
        self.precision = precision

    def __str__(self):
        if self.value:
            return self.value.isoformat()
        return super(BaseProperty, self).__str__()

    @property
    def serialized_value(self):
        if isinstance(self.value, list):
            return [x.isoformat() for x in self.value]
        elif self.value is None:
            return None
        else:
            return self.value.isoformat()

    But serialize_datetime in mixbox/dates.py serialize only scalar value.

    def serialize_datetime(value):
    """Attempts to convert `value` into an ISO8601-compliant timestamp string.
    If `value` is ``None``, ``None`` will be returned.

    Args:
        value: A datetime.datetime value.

    Returns:
        An ISO8601 formatted timestamp string.

    """
    if not value:
        return None
    return value.isoformat()

    So have made the following change in serialize_datetime

    def serialize_datetime(value):
    """Attempts to convert `value` into an ISO8601-compliant timestamp string.
    If `value` is ``None``, ``None`` will be returned.
    value can list,scalar or None

    Args:
        value: A datetime.datetime value. 

    Returns:
        An ISO8601 formatted timestamp string.

    """
    if isinstance(value, list):
        return [x.isoformat() for x in value]
    elif value is None:
        return None
    else:
        return value.isoformat()

    After making above changes, everything is working fine.
    PS: Please check changes,if you want I would push the changes.

  3. gtback commented on Jun 6, 2018

    @gtback
    gtback
    on Jun 6, 2018
    Contributor

    Thanks for the additional information, @ajnovice ! I don't think we should make a change in serialize_datetime, which is supposed to work on scalar values. It's likely somewhere in python-cybox (which allows fields to contain both single values or lists of values) that we should make this change. I'll create an issue there.

  4. gtback
    closed this as completedon Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions