Skip to content

Disallow setting of core construct definition properties when idref is set #175

Description

@bworrell

If an idref is set on an Indicator or other core construct, we unset the id_ property. It might be helpful to disallow the setting and exporting of other instance properties when idref is set, such as xsi:type. This would help address some of the concerns in #172

Activity

  1. added this to the v1.1.1.2 milestone on Aug 14, 2014
  2. imjonsnooow commented on Aug 28, 2014

    @imjonsnooow
    Contributor

    Question: should we go with a 'set it and forget it' method, or do we want to actively prohibit setting properties when idref is set? The easiest solution would be to check if idref is set in API objects' to_obj method, and not convert properties if idref is set. However, if we want to throw errors in these conditions, we'll have to modify all of the setters for all of the objects.

    Any preference as to which route we should go? I'm guessing we'll want to go with the latter, so people aren't confused when they try to set properties and those properties are silently dropped...

  3. self-assigned this
    on Oct 14, 2014
  4. modified the milestone: v1.1.1.2 on Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions