Skip to content

On helios, get PBS_JOBID associated with SRMJID - #139

Merged
MarcCote merged 2 commits into
SMART-Lab:masterfrom
slefrancois:helios_match_jobid
Sep 12, 2016
Merged

MarcCote merged 2 commits into
SMART-Lab:masterfrom
slefrancois:helios_match_jobid

Conversation

@slefrancois

Copy link
Copy Markdown
Contributor

solves #137

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.341% when pulling c00da88 on slefrancois:helios_match_jobid into 3685113 on SMART-Lab:master.

Comment thread scripts/smart-dispatch Outdated
for job in qstat_out:
if re.search(r"SRMJID:{job_id}".format(job_id=jobs_id[-1]), job):
pbs_job_id = re.match(r"[0-9a-zA-Z.-]*", job).group()
jobs_id[-1] = 'PBS_JOBID: {pbs}, SRMJID: {srm}'.format(pbs=pbs_job_id, srm=jobs_id[-1])

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only return pbs_job_id to have a consistent behavior with the other clusters.

Other than that this looks perfect to me.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.341% when pulling c39dc99 on slefrancois:helios_match_jobid into 3685113 on SMART-Lab:master.

@MarcCote

Copy link
Copy Markdown
Member

LGTM

@MarcCote
MarcCote merged commit ea735ba into SMART-Lab:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants