Skip to content

Implement input focus for Mac & Windows - #170

Merged
micahrj merged 9 commits into
RustAudio:masterfrom
dathinaios:master
Mar 25, 2024
Merged

Implement input focus for Mac & Windows#170
micahrj merged 9 commits into
RustAudio:masterfrom
dathinaios:master

Conversation

@dathinaios

Copy link
Copy Markdown
Contributor

As per #152. Still not working for VST but that appears to be due to a separate issue (see #169). I tested it in a nih_plug CLAP plugin in Reaper. I had to modify vizia_baseview to call set_input_focus when the alt-click event is triggered. Will also commit those changes there if this is accepted as a solution.

@micahrj

micahrj commented Mar 19, 2024

Copy link
Copy Markdown
Member

The Windows and Linux builds will fail without definitions of has_input_focus and set_input_focus on their platform::Window types. Please add some stub definitions with unimplemented!() to the Windows and Linux backends.

@dathinaios dathinaios changed the title Implement input focus for Mac Implement input focus for Mac & Windows Mar 21, 2024
Comment thread src/macos/window.rs Outdated
Comment thread src/win/window.rs Outdated
Comment thread src/window.rs Outdated
Comment thread src/win/window.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants