FreeBSD 12.2 - #161
Closed
fkorotkov wants to merge 1 commit into
Closed
Conversation
12.1 Reached End-Of-Life https://www.freebsd.org/releases/
Member
|
Thanks for the suggested fix! I fiddled the CI file before noticing your push request, but ended up in the same place. |
pull Bot
pushed a commit
to Mu-L/rsync
that referenced
this pull request
Aug 13, 2026
runtests.py already honours $scratchbase, but a target could not use it: the sudo branch runs `sudo -n env PATH="$PATH" ...`, which drops whatever env_prefix exported. Setting it there looked like it worked and silently ran on the default filesystem instead -- the first HFS+ run came back green for that reason. Give it a target field carried inside the env string, on both the root and non-root paths, shell-quoted so a volume name containing a space does not turn into a stray argument. The non-root pass also clears the relocated scratch, which a prior sudo run leaves root-owned outside builddir. expect_skip_omit is the mirror of expect_skip_extra: entries the workflow expects to skip which a target actually RUNS. Relocating the scratch supplies conditions the workflow's host lacks -- a separate volume makes backup-crossdev-copy and chmod-temp-dir reachable -- and without a way to subtract, such a target can never be green. mac2-hfs runs the same host and build as mac2 with the scratch on HFS+. It verifies the mount rather than assuming it: a stale directory, or a name collision attaching at "RsyncHFS 1", would otherwise leave the tests on APFS reporting green, which is how the first version lied. Ownership must be on as well, and is now checked rather than attempted: a user-attached image mounts "noowners", under which every uid/gid and permission check is meaningless, and that alone accounted for 28 of the 31 failures the first honest run produced. mac-x86 is the x86-64 Mac -- the only target that can build the x86-64 md5 assembly, since mac2 is arm64 where configure refuses --enable-md5-asm outright. It needs MacPorts for autotools, python3 and the crypto/hash libs. --enable-roll-simd is not set and cannot be: that probe uses GCC-style function multiversioning, which clang does not support on Mach-O, failing identically under Apple clang 10 and clang 19. mac-x86 currently BUILD-FAILs on the unguarded mknodat() in do_mknod_atfd() (RsyncProject#161), which it reproduced on its first run.
pull Bot
pushed a commit
to Mu-L/rsync
that referenced
this pull request
Aug 13, 2026
Nothing in CI or the fleet has ever set --enable-roll-simd, --enable-roll-asm
or --enable-md5-asm, which is why the over-read above sat behind a "fixed"
label for two months, and why the fix applied for it went to the wrong
assembly file.
mac-x86-asm is the same host and OS as mac-x86 with all three on. Mach-O is
the interesting part -- both problems reported against these flags were
macOS-x86-64 -- and it is the only machine in the fleet that can build the
x86-64 assembly at all.
It needs MacPorts clang 19 through CC/CXX, because Apple clang 10 (the ceiling
on macOS 10.13) rejects configure's target("default") multiversioning probe.
mac-x86 keeps the stock Apple compiler, which is what caught RsyncProject#161, so the two
cover different ground rather than one replacing the other.
simd-checksum is a macOS-wide expected skip, since simdtest is only built when
SIMD is enabled; this target subtracts it, because running it is the point.
Also corrects mac-x86's comment, which claimed the probe "cannot compile here
with any clang". It is a compiler-version limit: clang 19 on that same box
compiles, links and runs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12.1 Reached End-Of-Life https://www.freebsd.org/releases/