Skip to content

fix: test case 11 and 12 flaky tests - #7564

Merged
OtavioStasiak merged 9 commits into
developfrom
fix.flaky-test-room
Aug 12, 2026
Merged

fix: test case 11 and 12 flaky tests#7564
OtavioStasiak merged 9 commits into
developfrom
fix.flaky-test-room

Conversation

@OtavioStasiak

@OtavioStasiak OtavioStasiak commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Fix test case 11 and 12 failing on CI.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1488

How to test or reproduce

  • Run e2e tests;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes

    • Improved emoji autocomplete selection reliability.
    • Prevented unnecessary keyboard dismissal on iOS when selecting reactions.
    • Improved quoted-message interactions during message navigation.
  • Tests

    • Improved room navigation coverage across activity-sorted room lists.
    • Increased reliability when testing long threads, older messages, scrolling, message search, and cross-room thread navigation.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a36cca2-2466-4330-971f-7ff64e1a2e30

📥 Commits

Reviewing files that changed from the base of the PR and between 957b9df and ca76d3c.

📒 Files selected for processing (1)
  • .maestro/tests/room/room-last-message-thread-50-plus.yaml
💤 Files with no reviewable changes (1)
  • .maestro/tests/room/room-last-message-thread-50-plus.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: format
  • GitHub Check: ESLint and Test / run-eslint-and-test
  • GitHub Check: E2E Shard Preflight

Walkthrough

The room tests now wait for emoji autocomplete results, dismiss the keyboard only on Android, use search-based room navigation, and target quoted replies by reply element IDs.

Changes

Room test reliability

Layer / File(s) Summary
Autocomplete and keyboard flow
.maestro/tests/room/room.yaml
The test waits for autocomplete-item-joystick before selecting autocomplete-item-joy. Keyboard dismissal now runs only on Android.
Search-based room navigation and reply targeting
.maestro/tests/room/room-last-message-thread-50-plus.yaml, .maestro/tests/room/jump-to-message.yaml
Room fixtures use search-and-navigate-room.yaml instead of navigate-to-room.yaml. Quoted-message actions target reply element IDs.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the pull request as a fix for flaky test cases 11 and 12, matching the stated objectives and changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • NATIVE-1488: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread .maestro/tests/room/room.yaml Outdated
Comment thread .maestro/tests/room/room.yaml Outdated
Comment thread .maestro/tests/room/jump-to-message.yaml Outdated
@OtavioStasiak
OtavioStasiak deployed to approve_e2e_testing August 12, 2026 14:47 — with GitHub Actions Active
@OtavioStasiak OtavioStasiak changed the title fix: Room flaky test fix: test case 11 and 12 flaky tests Aug 12, 2026
@OtavioStasiak
OtavioStasiak merged commit 2257425 into develop Aug 12, 2026
8 of 9 checks passed
@OtavioStasiak
OtavioStasiak deleted the fix.flaky-test-room branch August 12, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants