Comment on Issues

[samad-yar-khan]

Why do we need this ?

As a GitHub App developer

I need to:

Add new modals to view issue details, issue comments and to add new comments to issue

So That:

Users can perform all the tasks related to GitHub Issues right from Rocket.Chat

Acceptance Criteria

• Make new modals to view issue details, issue comments and add new comments to an issue
• The user interaction should be similar to pull comments comments
• Make a check for authenticated users before giving access to any of these modals

Further Comments / References

• Pull Request Comments PR - PR 18

[varunsh17]

Hello @samad-yar-khan sir,
I would like to work upon this issue to contribute in Roket.chat
Can you share relevant details/folder/files/links/docs/concepts that will be helpful for me to tackle it ?

[samad-yar-khan]

Hey @varunsh17 , thankyou for showing interest in contributing to our project. You can go through the project wiki, Apps-engine documentation and the closed PRs for some inspiration.

Some Typescript Documentation incase you are new to Typescript

• Typescript HandBook - https://www.typescriptlang.org/docs/handbook/intro.html

Some Documentation to get you started with Apps-Engine :

• Apps-Engine Definitions : https://rocketchat.github.io/Rocket.Chat.Apps-engine/
• A medium article by one of the senior contributors and my mentor @RonLek. This which will walk you through a RC App - https://rohanlekhwani.medium.com/making-a-rocket-chat-app-8eaaa0263e39
• Rocket Chat Apps Developer Docs - https://developer.rocket.chat/apps-engine/rocketchat-app

The following links might help, as the underlying logic should be similar to adding comments to PRs.:

• https://github.com/RocketChat/Apps.Github22/wiki/Merge-PRs-and-Add-Comments
• Merge PR and Comment on PRs #18

[varunsh17]

After I did local setup as stated in HERE ,
When I type github login and then click on login button , I am getting "Page not found" in new tab..
I guess I am doing some mistake in Application setup, can you suggest me how to proceed ?
Thanks @samad-yar-khan

@samad-yar-khan

[samad-yar-khan]

Hey @varunsh17 apologies for the delayed response.

• Have you tried changing the home page url to /home instead of the channel.
• There was an issue which I ran into while setting up oath was that Rocket.Chat Apps Engine OAuth. There is an issue with the OAuth2 module of the apps engine where you need that at the end. otherwise the redirect URL generated by the internal callback will not have slash either, failing OAuth. Resolving this might solve issue.

[ayush3160]

Hi @samad-yar-khan , I would like to work on this issue.