Repository navigation
feat: the group close's blockers and override - #262
Merged
Merged
Conversation
Regenerated against robosystems with #1857–#1860. The fiscal calendar read names what holds the group close (group_open_entities, group_pending_adjustments, group_unexplained, group_not_footing), and LedgerClient.close_period takes allow_unexplained_residuals for the consolidation entity's close, which is the group's. Claude-Session: https://claude.ai/code/session_01M6TRefZ8MTAxax6pMxer4q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerated against robosystems with #1857–#1860, the group close (C3, first part):
group_open_entities,group_pending_adjustments,group_unexplainedandgroup_not_footing. They're selected in the hand-written calendar query, and they populate on the consolidation entity's calendar, whose close is the group's.allow_unexplained_residuals), threaded the same way as the other overrides.up_to_date) and the backfill request's new override.These are additive changes to the generated tier, so a client minor.
Server dependency
Publish only after robosystems v1.18.10 is live in prod. That release carries #1860. The calendar query now selects the four
group*fields, and on v1.18.9 GraphQL refuses an unknown field, which would break every calendar read through this client. The roboledger-app change that shows these blockers waits on this publish.Verified
The full gate passes, plus a new test that the group's blockers map and the override is sent.
🤖 Generated with Claude Code
https://claude.ai/code/session_01M6TRefZ8MTAxax6pMxer4q