Repository navigation
Verify emulator root access for signed upgrade tests - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alpha18 signing run initially failed before candidate installation because
adb rootreturned 1 and the upgrade helper discarded its diagnostics. Check the reconnected emulator's UID before accessing the synthetic upgrade fixture, allow a root restart disconnect only when UID 0 is verified, and surface command output on failure with bounded waits.Area: Android release-test tooling only. Package code, APK, tag, signing identity, preservation assertions and desktop remain unchanged. Stop after verified fixture behavior and CI.
Validation: all 17 Python tooling tests passed, including restart-disconnect, unprivileged-device and reconnect-timeout cases. The updated helper seeded and verified its fixture across a signed alpha18 reinstall on the local API 35 emulator. Android CI is required before merge.
The original protected signing run 35417085075 passed on attempt 2 and published alpha18 before this helper change. Its exact root-failure cause remains unconfirmed; this follow-up verifies the required postcondition and improves failure diagnostics without weakening the preservation assertions or changing that published APK.