Repository navigation
Make Android settings honor Apply and Cancel; prepare alpha18 - #56
Merged
Merged
Conversation
RioPlay
marked this pull request as ready for review
September 19, 2026 02:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings promised Apply/Cancel, but voice, Reset and preview quick controls saved immediately. Theme/layout choices could not reliably switch back and did not refresh the preview. Every settings change now stays staged; Apply remains visible during scrolling and controls precede practice.
Dispose old preview panels, handle platform Back navigation, restore search consistently, retain only pending preferences across rotation, and shorten the preview language label. Prepare version 18 / alpha18 and release notes including the previously merged typing/suggestion stabilization. No new dependencies, permissions or desktop changes.
Validation on the final local candidate: 14 tooling tests, 40 JVM tests, 28 focused API 35 instrumentation tests, lint (0 errors), debug/release/test APK builds and release metadata checks passed. App-owned default, narrow/large-text and landscape captures reviewed; two geometry capture checks passed. The added Back test's thread-helper defect was fixed before the final passing run. Reviewed final source/diff against the settings and alpha18 contracts. Full exact-head CI is pending; physical phone, assistive technology and real Obtainium acceptance remain open.