Skip to content

RG-T132 Fixed Weather alerts info, fixed timezone issue - #277

Merged
ucswift merged 1 commit into
masterfrom
develop
Aug 20, 2026
Merged

RG-T132 Fixed Weather alerts info, fixed timezone issue#277
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Aug 20, 2026

Copy link
Copy Markdown
Member

This pull request updates weather alert handling to match the current alert data shape and fixes incorrect time usage in alert displays and logic.

What changed

  • Fixed weather alert field mappings

    • Updated the app to use the correct weather alert properties for:
      • alert category
      • instruction text
      • sender
    • This ensures weather alert details and cards display the expected information from the API.
  • Fixed weather alert date/time handling

    • Updated weather alert detail screens, alert cards, sorting, and active-alert checks to prefer the new UTC timestamp fields (EffectiveOnUtc, OnsetOnUtc, ExpiresOnUtc) when available.
    • Falls back to the older fields when the newer UTC values are not present.
    • This addresses timezone-related issues where alert times could appear offset or be used incorrectly in date comparisons.
  • Updated weather alert model

    • Brought the mobile model in line with the current v4 weather alert response by adding/removing/renaming fields accordingly.
    • Includes support for newer metadata returned by the backend.
  • Updated related tests

    • Adjusted weather alert component and store tests to use the corrected weather alert property names and updated data contract.
  • Minor UI adjustment

    • Increased tab sizing on the call detail screen for improved tab presentation.

@Resgrid-Bot

Resgrid-Bot commented Aug 20, 2026

Copy link
Copy Markdown

Code Review Could Not Complete ⚠️

The review failed before suggestions could be generated.

Reason: Rate limit reached on the provider (openai). Try again in a few minutes.

After fixing the issue, comment @kody review on this PR to re-run the review.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 59 minutes

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ab5bc6e-e053-4139-8d03-c90ee3ccd21f

📥 Commits

Reviewing files that changed from the base of the PR and between ea172d0 and 7f6a872.

📒 Files selected for processing (8)
  • src/app/call/[id].tsx
  • src/app/weather-alert/[id].tsx
  • src/components/weather-alerts/__tests__/weather-alert-banner.test.tsx
  • src/components/weather-alerts/__tests__/weather-alert-card.test.tsx
  • src/components/weather-alerts/weather-alert-card.tsx
  • src/lib/weather-alert-utils.ts
  • src/models/v4/weatherAlerts/weatherAlertResultData.ts
  • src/stores/weather-alerts/__tests__/store.test.ts

Comment @coderabbitai help to get the list of available commands.

@ucswift

ucswift commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

Approve

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift
ucswift merged commit d11fd5f into master Aug 20, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants